Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

View Change

1 comment:

• Patchset:

  • Patch Set #6:

    +1 to getting the right abstraction from the beginning, libflashrom entry-points is certainly that w […]

    Thanks Nico and Edward for the points above. I've gone through the writeprotect code and deleted anything that assumed it was being called from a CLI environment, i.e. it doesn't print any errors to stderr now.

    That also required breaking up some functions into smaller operations, which I think is generally better. All writeprotect functions are now exposed through libflashrom.h.

    As for splitting off a new CLI binary, I've factored out most of the WP related CLI code into a separate function (wp_cli() in review.coreboot.org/c/flashrom/+/58738/3), so it will be pretty easy to move everything. For now though maybe we can leave it in cli_classic while we finish off the core WP functionality?

To view, visit change 58482. To unsubscribe, or for help writing mail filters, visit settings.