Attention is currently required from: Richard Hughes, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Patrick Rudolph, Peter Marheine.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 )
Change subject: libflashrom: Return progress state to the library user
......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS4:
I think the context of adding support to programmers is useful to understand the needs of the framew […]
Ack
File 82802ab.c:
https://review.coreboot.org/c/flashrom/+/49643/comment/8b1cdcaa_67209e22
PS8, Line 137: set_progress(flash, FLASHROM_PROGRESS_WRITE, i + 1, len);
Updating progress on every byte seems pretty costly. […]
Does it make sense to switch the callback method to take a `int percentage` instead of current and total and have the callback be called max 100 times instead on each byte update?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7197572bb7f19e3bdb2bde855d70a0f50fd3854c
Gerrit-Change-Number: 49643
Gerrit-PatchSet: 9
Gerrit-Owner: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-CC: Richard Hughes
hughsient@gmail.com
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Richard Hughes
richard@hughsie.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Tue, 19 Apr 2022 17:21:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment