Attention is currently required from: Richard Hughes, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Patrick Rudolph, Peter Marheine.

View Change

2 comments:

• Patchset:

  • Patch Set #4:

    I think the context of adding support to programmers is useful to understand the needs of the framew […]

    Ack

• File 82802ab.c:

  • Patch Set #8, Line 137: set_progress(flash, FLASHROM_PROGRESS_WRITE, i + 1, len);

    Updating progress on every byte seems pretty costly. […]

    Does it make sense to switch the callback method to take a `int percentage` instead of current and total and have the callback be called max 100 times instead on each byte update?

To view, visit change 49643. To unsubscribe, or for help writing mail filters, visit settings.