Change in flashrom[master]: flashrom: Drop read_flash_to_file() usage

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Nico Huber, Angel Pons, Daniel Campello, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59291 )

Change subject: flashrom: Drop read_flash_to_file() usage
......................................................................


Patch Set 7:

(1 comment)

File cli_classic.c:

https://review.coreboot.org/c/flashrom/+/59291/comment/170c4ccf_02c36805 
PS4, Line 635: 			if (map_flash(&flashes[0]) != 0) {
             : 				free(flashes[0].chip);
             : 				ret = 1;
             : 				goto out_shutdown;
             : 			}
             : 			msg_cinfo("Please note that forced reads most likely contain garbage.\n");
             : 			ret = do_read(&flashes[0], filename);
             : 			unmap_flash(&flashes[0]);
> > That is a good point, I removed them. […]
> > 100% makes sense, I put the easy part out into https://review.coreboot.org/c/flashrom/+/60430 and kept this hunk in this change-id so the discussion thread doesn't get mixed up.

Good call on the PWM, will try to jig something up at home outside the lab to see if I can make that happen.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/59291
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4b690b688acf9d5deb46e8642a252a2132ea8c73
Gerrit-Change-Number: 59291
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Daniel Campello <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Nico Huber <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Daniel Campello <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Comment-Date: Wed, 29 Dec 2021 00:04:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <[e-mail]>
Comment-In-Reply-To: Edward O'Callaghan <[e-mail]>
Gerrit-MessageType: comment