Attention is currently required from: Nico Huber, Angel Pons, Daniel Campello, Anastasia Klimchuk.

View Change

1 comment:

• File cli_classic.c:

  • Patch Set #4, Line 635:

    			if (map_flash(&flashes[0]) != 0) {
    				free(flashes[0].chip);
    				ret = 1;
    				goto out_shutdown;
    			}
    			msg_cinfo("Please note that forced reads most likely contain garbage.\n");
    			ret = do_read(&flashes[0], filename);
    			unmap_flash(&flashes[0]);
    

    > That is a good point, I removed them. […]

    100% makes sense, I put the easy part out into https://review.coreboot.org/c/flashrom/+/60430 and kept this hunk in this change-id so the discussion thread doesn't get mixed up.

    Good call on the PWM, will try to jig something up at home outside the lab to see if I can make that happen.

To view, visit change 59291. To unsubscribe, or for help writing mail filters, visit settings.