Attention is currently required from: Nikolai Artemiev. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52883 )
Change subject: flashchips.c: merge GD25B128B/GD25Q128B and GD25Q127C/GD25Q128C ......................................................................
Patch Set 2:
(2 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/52883/comment/6f46bb71_ed564385 PS2, Line 6585: GD25Q127C this one is already wrong, since there is no QPI support. see my other comment
https://review.coreboot.org/c/flashrom/+/52883/comment/147b701a_638c9c76 PS2, Line 6274: GD25B128B
The 25B versions don't support QPI (only regular Quad-SPI wich uses a
single wire for the command). The 25Q128B and C versions were probably added separately because of minor differences (OTP sizes and SFDP support?).
Just one tiny addition, since I stumbled upon that, too: What you say is right - the 25B don't support QPI. However, not all 25Q do support it. One exmaple is GD25Q127C, which lacks QPI support but has the QPI flag in flashrom. That means we already have a conflict here :/