David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31014 ) Change subject: layout: Add interface to create a dynamically growing layout ...................................................................... Patch Set 3: Code-Review-1 (1 comment) I took a swing at rebasing this patch chain, hopefully we can get it in in the not-too-distant future. https://review.coreboot.org/c/flashrom/+/31014/3/layout.c File layout.c: https://review.coreboot.org/c/flashrom/+/31014/3/layout.c@378 PS3, Line 378: snprintf(dyn->base.entries[i].name, sizeof(dyn->base.entries[i].name), "%s", name); This line is what's causing the build failure: layout.c: In function 'add_layout_entry': layout.c:378:44: error: argument to 'sizeof' in 'snprintf' call is the same expression as the destination; did you mean to provide an explicit length? [-Werror=sizeof-pointer-memaccess] snprintf(dyn->base.entries[i].name, sizeof(dyn->base.entries[i].name), "%s", name); Looking at it a bit more closely, are you sure memory is being allocated for the name string? -- To view, visit https://review.coreboot.org/c/flashrom/+/31014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0093de58bc7eadc5cd52355937df23c4a6e934ed Gerrit-Change-Number: 31014 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 01 Dec 2019 23:46:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment