I took a swing at rebasing this patch chain, hopefully we can get it in in the not-too-distant future.

Patch set 3:Code-Review -1

View Change

1 comment:

• File layout.c:

  • Patch Set #3, Line 378: snprintf(dyn->base.entries[i].name, sizeof(dyn->base.entries[i].name), "%s", name);

    This line is what's causing the build failure:
    layout.c: In function 'add_layout_entry':
    layout.c:378:44: error: argument to 'sizeof' in 'snprintf' call is the same expression as the destination; did you mean to provide an explicit length? [-Werror=sizeof-pointer-memaccess]
      snprintf(dyn->base.entries[i].name, sizeof(dyn->base.entries[i].name), "%s", name);

    Looking at it a bit more closely, are you sure memory is being allocated for the name string?

To view, visit change 31014. To unsubscribe, or for help writing mail filters, visit settings.