David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31014 )
Change subject: layout: Add interface to create a dynamically growing layout ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
I took a swing at rebasing this patch chain, hopefully we can get it in in the not-too-distant future.
https://review.coreboot.org/c/flashrom/+/31014/3/layout.c File layout.c:
https://review.coreboot.org/c/flashrom/+/31014/3/layout.c@378 PS3, Line 378: snprintf(dyn->base.entries[i].name, sizeof(dyn->base.entries[i].name), "%s", name); This line is what's causing the build failure: layout.c: In function 'add_layout_entry': layout.c:378:44: error: argument to 'sizeof' in 'snprintf' call is the same expression as the destination; did you mean to provide an explicit length? [-Werror=sizeof-pointer-memaccess] snprintf(dyn->base.entries[i].name, sizeof(dyn->base.entries[i].name), "%s", name);
Looking at it a bit more closely, are you sure memory is being allocated for the name string?