Attention is currently required from: Nico Huber, Edward O'Callaghan. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30979 ) Change subject: [RFC] cli_classic: Add `--mode (read|write|verify|erase)` parameter ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I believe the main difference between this approach and CB:52362 is that this -m argument is only needed if no -r/-v/-w <file> is specified but not needed/allowed otherwise. With this apporach: - If someone wants to read a region *and* the whole chip: # flashrom -i region:region-file.bin -r chip-file.bin - If someone wants to read a region *and not* the whole chip: # flashrom -i region:region-file.bin -m r With CB:52362 - If someone wants to read a region *and* the whole chip: # flashrom -i region:region-file.bin -r chip-file.bin - If someone wants to read a region *and not* the whole chip: # flashrom -i region:region-file.bin -r I *personally* think having -r do the signaling for both types of reads is cleaner given that -m won't be used for "normal" full chip reads. As an a side (not that I'm saying this should be a deciding factor for upstream direction): the second approach should be compatible with chromium usage and will keep both CLIs almost ("almost" chromium has a couple of additional flags --do-not-diff and --ignore-lock) aligned as of today. -- To view, visit https://review.coreboot.org/c/flashrom/+/30979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idfba11ec9991aac423b07f68f7dc45e7bebbb06b Gerrit-Change-Number: 30979 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <hailfinger@gmail.com> Gerrit-Reviewer: Daniel Campello <campello@chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: Stefan T <stefan.tauner@gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Comment-Date: Fri, 07 May 2021 00:35:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment