Attention is currently required from: Nico Huber, Edward O'Callaghan.

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    I believe the main difference between this approach and CB:52362 is that this -m argument is only needed if no -r/-v/-w <file> is specified but not needed/allowed otherwise.

    With this apporach:

    • If someone wants to read a region *and* the whole chip:
    • # flashrom -i region:region-file.bin -r chip-file.bin
    • If someone wants to read a region *and not* the whole chip:
    • # flashrom -i region:region-file.bin -m r

    With CB:52362

    • If someone wants to read a region *and* the whole chip:
    • # flashrom -i region:region-file.bin -r chip-file.bin
    • If someone wants to read a region *and not* the whole chip:
    • # flashrom -i region:region-file.bin -r

    I *personally* think having -r do the signaling for both types of reads is cleaner given that -m won't be used for "normal" full chip reads.

    As an a side (not that I'm saying this should be a deciding factor for upstream direction): the second approach should be compatible with chromium usage and will keep both CLIs almost ("almost" chromium has a couple of additional flags --do-not-diff and --ignore-lock) aligned as of today.

To view, visit change 30979. To unsubscribe, or for help writing mail filters, visit settings.