Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40901 )
Change subject: lspcon_i2c_spi.c: Switch logs with 'Error:' to '__func__:' ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/flashrom/+/40901/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/40901/3//COMMIT_MSG@7 PS3, Line 7: Switch Prefix with fn name instead of just 'Error:'
https://review.coreboot.org/c/flashrom/+/40901/3//COMMIT_MSG@9 PS3, Line 9: Showing Error is not very informative and switch to function : name to make it easy for debug. Replaces log lines with the prefix formatter '%s: ..' and pass '__func__' to the printers so that errors are prefixed with the function from which they originated.
https://review.coreboot.org/c/flashrom/+/40901/3//COMMIT_MSG@11 PS3, Line 11: remove all this indentation.