View Change
3 comments:
Commit Message:
Patch Set #3, Line 7: Switch
Prefix with fn name instead of just 'Error:'
Patch Set #3, Line 9:
Showing Error is not very informative and switch to function
name to make it easy for debug.
Replaces log lines with the prefix formatter '%s: ..' and pass '__func__' to the printers so that errors are prefixed with the function from which they originated.
Patch Set #3, Line 11:
remove all this indentation.
To view, visit change 40901. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If3205d8e453cfcd37f725b4fd135fe1221c913c0
Gerrit-Change-Number: 40901
Gerrit-PatchSet: 3
Gerrit-Owner: Shiyu Sun <sshiyu@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 30 Apr 2020 07:07:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment