Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33639 )
Change subject: Add support for MX25U25635F ......................................................................
Patch Set 2:
(3 comments)
Thanks for your patch. There's one nit in the commit message and some missed erase block commands to be added. Then it's ready to go.
I believe I've addressed the comments you had, but please let me know if I've not done it correctly.
Some white-space issues and something I forgot to mention ._.
This is my first time contributing to this project, but I think I've covered it.
You are doing great so far :)
https://review.coreboot.org/#/c/33639/1/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/33639/1/flashchips.c@8884 PS1, Line 8884: { : .eraseblocks = { {4 * 1024, 8192} }, : .block_erase = spi_block_erase_20, : }, { : .eraseblocks = { {32 * 1024, 1024} }, : .block_erase = spi_block_erase_52, : }, { : .eraseblocks = { {64 * 1024, 512} }, : .block_erase = spi_block_erase_d8, : }, {
Done
Sorry, I forgot to mention that order matters, the native 4BA versions should come first. See next chip, for instance.
https://review.coreboot.org/#/c/33639/2/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/33639/2/flashchips.c@8888 PS2, Line 8888: .eraseblocks = { {4 * 1024, 8192} }, : .block_erase = spi_block_erase_21, : }, { Use tabs for indentation (and one tab is 8 spaces anyway).
https://review.coreboot.org/#/c/33639/2/flashchips.c@8893 PS2, Line 8893: }, { dito