Thanks for your patch. There's one nit in the commit message
and some missed erase block commands to be added. Then it's
ready to go.

I believe I've addressed the comments you had, but please let me know if I've not done it correctly.

Some white-space issues and something I forgot to mention ._.

This is my first time contributing to this project, but I think I've covered it.

You are doing great so far :)

View Change

3 comments:

• File flashchips.c:

  • Patch Set #1, Line 8884:

    			{
    				.eraseblocks = { {4 * 1024, 8192} },
    				.block_erase = spi_block_erase_20,
    			}, {
    				.eraseblocks = { {32 * 1024, 1024} },
    				.block_erase = spi_block_erase_52,
    			}, {
    				.eraseblocks = { {64 * 1024, 512} },
    				.block_erase = spi_block_erase_d8,
    			}, {
    

    Done

    Sorry, I forgot to mention that order matters, the native 4BA versions
    should come first. See next chip, for instance.

• File flashchips.c:

  • Patch Set #2, Line 8888:

    			  .eraseblocks = { {4 * 1024, 8192} },
    			  .block_erase = spi_block_erase_21,
          }, {
    

    Use tabs for indentation (and one tab is 8 spaces anyway).

  • Patch Set #2, Line 8893: }, {

    dito

To view, visit change 33639. To unsubscribe, or for help writing mail filters, visit settings.