Thanks for your patch. There's one nit in the commit message
and some missed erase block commands to be added. Then it's
ready to go.

I believe I've addressed the comments you had, but please let me know if I've not done it correctly.

Some white-space issues and something I forgot to mention ._.

This is my first time contributing to this project, but I think I've covered it.

You are doing great so far :)

View Change


To view, visit change 33639. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5bdcd32acd1942edf65e50bce0f81c836095ee8c
Gerrit-Change-Number: 33639
Gerrit-PatchSet: 2
Gerrit-Owner: David Tomaschik <>
Gerrit-Reviewer: Angel Pons <>
Gerrit-Reviewer: David Tomaschik <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-Comment-Date: Sat, 22 Jun 2019 13:59:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Tomaschik <>
Comment-In-Reply-To: Nico Huber <>
Gerrit-MessageType: comment