Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Anastasia Klimchuk, Peter Marheine.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33542 )
Change subject: layout: Introduce layout_next()
......................................................................
Patch Set 3:
(2 comments)
File layout.c:
https://review.coreboot.org/c/flashrom/+/33542/comment/3cfbbb18_834637c4
PS2, Line 274:
: const struct romentry *layout_next_included(
: const struct flashrom_layout *const layout, const struct romentry *iterator)
: {
: while ((iterator = layout_next(layout, iterator))) {
: if (iterator->included)
: break;
: }
: return iterator;
: }
Maybe move this above _layout_next to align with the header file
Done
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/33542/comment/c234f907_7ce8a329
PS2, Line 351: chip_entry = layout_next(&chip_layout->base, chip_entry);
: dump_entry = layout_next(&dump_layout.base, dump_entry);
Looks weird that one of these uses '->' and the other uses '. […]
Anything to do about it? I could add more pointers, but I don't think
it would become more readable. It will get unified later in this train
anyway.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33542
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I284958471c61344d29d92c95d88475065a9ca9aa
Gerrit-Change-Number: 33542
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Thu, 13 May 2021 23:19:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment