[flashrom-gerrit] Change in flashrom[master]: layout: Introduce layout_next()

[Nico Huber (Code Review)]

Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Anastasia Klimchuk, Peter Marheine.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33542 )

Change subject: layout: Introduce layout_next()
......................................................................


Patch Set 3:

(2 comments)

File layout.c:

https://review.coreboot.org/c/flashrom/+/33542/comment/3cfbbb18_834637c4 
PS2, Line 274: 
             : const struct romentry *layout_next_included(
             : 		const struct flashrom_layout *const layout, const struct romentry *iterator)
             : {
             : 	while ((iterator = layout_next(layout, iterator))) {
             : 		if (iterator->included)
             : 			break;
             : 	}
             : 	return iterator;
             : }
> Maybe move this above _layout_next to align with the header file
> Done

File libflashrom.c:

https://review.coreboot.org/c/flashrom/+/33542/comment/c234f907_7ce8a329 
PS2, Line 351: 			chip_entry = layout_next(&chip_layout->base, chip_entry);
             : 			dump_entry = layout_next(&dump_layout.base, dump_entry);
> Looks weird that one of these uses '->' and the other uses '. […]
> Anything to do about it? I could add more pointers, but I don't think
> it would become more readable. It will get unified later in this train
> anyway.