Nico Huber has posted comments on this change. ( https://review.coreboot.org/26946 )
Change subject: bitbang_spi: Add functions to optimize xfers ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
As this changes the timing, I would like some confirmation that it doesn't break nicintel_spi (the only bitbang master that sets .half_period). I would expect it to work fine, though, and assume that the delay is not needed for it anyway.
https://review.coreboot.org/#/c/26946/2/bitbang_spi.c File bitbang_spi.c:
https://review.coreboot.org/#/c/26946/2/bitbang_spi.c@114 PS2, Line 114: bitbang_spi_set_sck_set_mosi(master, 0, 0); Shouldn't we start with CLK = 1 now?
https://review.coreboot.org/#/c/26946/2/bitbang_spi.c@157 PS2, Line 157: bitbang_spi_set_sck(master, 0); Wouldn't be needed if we assume CLK = 1 between commands.