As this changes the timing, I would like some confirmation that
it doesn't break nicintel_spi (the only bitbang master that sets
.half_period). I would expect it to work fine, though, and assume
that the delay is not needed for it anyway.

Patch set 2:Code-Review +1

View Change

2 comments:

• File bitbang_spi.c:

  • Patch Set #2, Line 114: bitbang_spi_set_sck_set_mosi(master, 0, 0);

    Shouldn't we start with CLK = 1 now?

  • Patch Set #2, Line 157: bitbang_spi_set_sck(master, 0);

    Wouldn't be needed if we assume CLK = 1 between commands.

To view, visit change 26946. To unsubscribe, or for help writing mail filters, visit settings.