Change in flashrom[master]: bitbang_spi: Add functions to optimize xfers

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26946 )

Change subject: bitbang_spi: Add functions to optimize xfers
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

As this changes the timing, I would like some confirmation that
it doesn't break nicintel_spi (the only bitbang master that sets
.half_period). I would expect it to work fine, though, and assume
that the delay is not needed for it anyway.

https://review.coreboot.org/#/c/26946/2/bitbang_spi.c
File bitbang_spi.c:

https://review.coreboot.org/#/c/26946/2/bitbang_spi.c@114
PS2, Line 114: 	bitbang_spi_set_sck_set_mosi(master, 0, 0);
Shouldn't we start with CLK = 1 now?


https://review.coreboot.org/#/c/26946/2/bitbang_spi.c@157
PS2, Line 157: 	bitbang_spi_set_sck(master, 0);
Wouldn't be needed if we assume CLK = 1 between commands.



-- 
To view, visit https://review.coreboot.org/26946
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3430a9df34844cdfa82e109456be788eaa1789a
Gerrit-Change-Number: 26946
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Thompson <[e-mail]>
Gerrit-Reviewer: Idwer Vollering <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sun, 24 Jun 2018 11:26:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes