Attention is currently required from: Daniel Campello, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59921 )
Change subject: flashrom.c: extract operation only uses layout files ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/59921/comment/2f6a9ab5_221551cb PS1, Line 9: Extract : operation reads the layout regions to filenames with equal name to the : specified layout regions. Do you mean to say -
"The extract operation reads out the layout regions to filenames corresponding to the respective layout region names."
The previous sentence is sort of hard to parse.
https://review.coreboot.org/c/flashrom/+/59921/comment/8f2f6fbe_f8211fd3 PS1, Line 16: C upstream needs a sign-off line
https://review.coreboot.org/c/flashrom/+/59921/comment/9ddc1300_755ef069 PS1, Line 16: Change-Id: Ibc9a4e2966385863345f06662521d6d0e4685121 BUG=/TEST= are useful.
Patchset:
PS1: Thanks for the patch!
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/59921/comment/5ba3d812_75471ad3 PS1, Line 1076: read_flash_to_file( as this relates, could you take a look at https://review.coreboot.org/c/flashrom/+/59291 please Daniel?