Attention is currently required from: Daniel Campello, Anastasia Klimchuk.

View Change

5 comments:

• Commit Message:

  • Patch Set #1, Line 9:

    Extract
    operation reads the layout regions to filenames with equal name to the
    specified layout regions.
    

    Do you mean to say -

    "The extract operation reads out the layout regions to filenames corresponding to the respective layout region names."

    The previous sentence is sort of hard to parse.

  • Patch Set #1, Line 16: C

    upstream needs a sign-off line

  • Patch Set #1, Line 16: Change-Id: Ibc9a4e2966385863345f06662521d6d0e4685121

    BUG=/TEST= are useful.

• Patchset:

  • Patch Set #1:

    Thanks for the patch!

• File flashrom.c:

  • Patch Set #1, Line 1076: read_flash_to_file(

    as this relates, could you take a look at https://review.coreboot.org/c/flashrom/+/59291 please Daniel?

To view, visit change 59921. To unsubscribe, or for help writing mail filters, visit settings.