Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62320 )
Change subject: tests/: Allow for file path validation ......................................................................
Patch Set 8:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62320/comment/f69d298b_8888475b PS4, Line 7: Allow for file path validation
I added some comments about commit messages in previous patches, this one would need to be aligned a […]
Again, no multiple paths even when they are supported by the framework.
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/62320/comment/12992ca2_a0c86ca4 PS4, Line 61: data
Why dummy needs mocks? This is unexpected [to me].
This is actually making sure that no open() calls are made.
https://review.coreboot.org/c/flashrom/+/62320/comment/cb76970d_d3c21b63 PS4, Line 80: data
Same comment as in previous patches: let's be more specific with naming and call this `nicrealtek_io […]
Done
https://review.coreboot.org/c/flashrom/+/62320/comment/e19c58ea_5ef5005f PS4, Line 89:
Lets add new line before and after `io_mock_register`
Done
https://review.coreboot.org/c/flashrom/+/62320/comment/b35a2d1b_9d12bac8 PS4, Line 90:
Since this test now registering io mock, it also needs to unregister, which is […]
Done