Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.

View Change

5 comments:

• Commit Message:

  • Patch Set #4, Line 7: Allow for file path validation

    I added some comments about commit messages in previous patches, this one would need to be aligned a […]

    Again, no multiple paths even when they are supported by the framework.

• File tests/init_shutdown.c:

  • Patch Set #4, Line 61: data

    Why dummy needs mocks? This is unexpected [to me].

    This is actually making sure that no open() calls are made.

  • Patch Set #4, Line 80: data

    Same comment as in previous patches: let's be more specific with naming and call this `nicrealtek_io […]

    Done

  • Patch Set #4, Line 89:

    Lets add new line before and after `io_mock_register`

    Done

  • Patch Set #4, Line 90:

    Since this test now registering io mock, it also needs to unregister, which is […]

    Done

To view, visit change 62320. To unsubscribe, or for help writing mail filters, visit settings.