[flashrom-gerrit] [S] Change in flashrom[main]: ich: Add names for region 5, 9, 10, 11, 12, 15

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Hsuan-ting Chen, Stefan Reinauer, Subrata Banik.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81356?usp=email )

Change subject: ich: Add names for region 5, 9, 10, 11, 12, 15
......................................................................

Patch Set 7: Code-Review+2

(1 comment)

File util/ich_descriptors_tool/ich_descriptors_tool.c:

https://review.coreboot.org/c/flashrom/+/81356/comment/2503b8cf_7912b258 :
PS5, Line 42: 10GbE0
> The OpROM is located on 10GbE#2, not 10GbE#1. While I considered changing the output to:

Region 12 (10GbE1/OpROM) is unused.
...this would require significant code modifications due to padding width adjustments. I've decided to postpone this change for now.

Yes, my typo, it would be in the place of 10GbE2 !

I think your idea is very good, to update region name as 10GbE2/OpROM (since it's used in a generic way), but certainly it goes outside the scope of the patch. If you decide to do this later, you will, of course, be very welcome!