Attention is currently required from: Hsuan-ting Chen, Stefan Reinauer, Subrata Banik.

Patch set 7:Code-Review +2

View Change

1 comment:

• File util/ich_descriptors_tool/ich_descriptors_tool.c:

  • Patch Set #5, Line 42: 10GbE0

    The OpROM is located on 10GbE#2, not 10GbE#1. While I considered changing the output to:
    Region 12 (10GbE1/OpROM) is unused.
    ...this would require significant code modifications due to padding width adjustments. I've decided to postpone this change for now.

    Yes, my typo, it would be in the place of 10GbE2 !

    I think your idea is very good, to update region name as 10GbE2/OpROM (since it's used in a generic way), but certainly it goes outside the scope of the patch. If you decide to do this later, you will, of course, be very welcome!

To view, visit change 81356. To unsubscribe, or for help writing mail filters, visit settings.