[flashrom-gerrit] Change in ...flashrom[master]: Add support for MX25U25635F

[David Tomaschik (Code Review)]

David Tomaschik has posted comments on this change. (
https://review.coreboot.org/c/flashrom/+/33639 )

Change subject: Add support for MX25U25635F
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/33639/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33639/1//COMMIT_MSG@7 
PS1, Line 7: Add support for MX25U25635F.
  No full-stop at end of summary, please.
Done


https://review.coreboot.org/#/c/33639/1//COMMIT_MSG@10 
PS1, Line 10: Tested successfully for probe/read.
  Any tests with write/erase?
Unfortunately not, I
only have one chip, and it's in a device we can't have down for a significant
period of time if things go wrong.


https://review.coreboot.org/#/c/33639/1/flashchips.c 
File flashchips.c:

https://review.coreboot.org/#/c/33639/1/flashchips.c@8884 
PS1, Line 8884: 			{
              : 				.eraseblocks = { {4 * 1024, 8192} },
              : 				.block_erase = spi_block_erase_20,
              : 			}, {
              : 				.eraseblocks = { {32 * 1024, 1024} },
              : 				.block_erase = spi_block_erase_52,
              : 			}, {
              : 				.eraseblocks = { {64 * 1024, 512} },
              : 				.block_erase = spi_block_erase_d8,
              : 			}, {
  Native 4BA erase versions should also be mentioned:
21, 5c, dc
Done



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/33639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5bdcd32acd1942edf65e50bce0f81c836095ee8c
Gerrit-Change-Number: 33639
Gerrit-PatchSet: 2
Gerrit-Owner: David Tomaschik <davidtomaschik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Tomaschik <davidtomaschik(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 22 Jun 2019 01:10:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment