Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30995 )
Change subject: ichspi: Add Apollo Lake support ......................................................................
Uploaded patch set 2.
(6 comments)
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@244 PS1, Line 244: 7
I don't know if it matters. "14 MHz / 17 MHz" may be good.
Done
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@348 PS1, Line 348: "Descr.", "BIOS", "ME", "GbE", "Platf.", "DevExt", "BIOS2", "unknown",
Dev*Exp*
Done
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@348 PS1, Line 348: ME
Somewhere should be a hint that APL differs from other platforms. It must not be here. […]
I've decided to leave it as is (if that can get approval): It never was flashrom's purpose to care about the flash contents. Actually, I think "ME" is most honest. While it doesn't contain all possible software running on the ME, it is what the ME might boot from.
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@452 PS1, Line 452: msg_pdbg2(" FD IFWI TXE n/a Platf DevExt\n");
Dev*Exp*
Done
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@452 PS1, Line 452: TXE
This string is APL specific. […]
These are the terms used in the "SPI and SMIP Guide", I would like to keep it consistent.
https://review.coreboot.org/#/c/30995/1/ichspi.c File ichspi.c:
https://review.coreboot.org/#/c/30995/1/ichspi.c@1572 PS1, Line 1572: "Gigabit Ethernet", "Platform Data", "Device Extension",
Device *Expansion*
Done