Uploaded patch set 2.

(6 comments)

View Change

6 comments:

• File ich_descriptors.c:

  • Patch Set #1, Line 244: 7

    I don't know if it matters. "14 MHz / 17 MHz" may be good.

    Done

  • Patch Set #1, Line 348: "Descr.", "BIOS", "ME", "GbE", "Platf.", "DevExt", "BIOS2", "unknown",

    Dev*Exp*

    Done

  • Patch Set #1, Line 348: ME

    Somewhere should be a hint that APL differs from other platforms. It must not be here. […]

    I've decided to leave it as is (if that can get approval):
    It never was flashrom's purpose to care about the flash
    contents. Actually, I think "ME" is most honest. While it
    doesn't contain all possible software running on the ME,
    it is what the ME might boot from.

  • Patch Set #1, Line 452: msg_pdbg2(" FD IFWI TXE n/a Platf DevExt\n");

    Dev*Exp*

    Done

  • Patch Set #1, Line 452: TXE

    This string is APL specific. […]

    These are the terms used in the "SPI and SMIP Guide", I would like to keep
    it consistent.

• File ichspi.c:

  • Patch Set #1, Line 1572: "Gigabit Ethernet", "Platform Data", "Device Extension",

    Device *Expansion*

    Done

To view, visit change 30995. To unsubscribe, or for help writing mail filters, visit settings.