[flashrom-gerrit] Change in ...flashrom[master]: ichspi: Add Apollo Lake support

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. (
https://review.coreboot.org/c/flashrom/+/30995 )

Change subject: ichspi: Add Apollo Lake support
......................................................................


Uploaded patch set 2.

(6 comments)

https://review.coreboot.org/#/c/30995/1/ich_descriptors.c 
File ich_descriptors.c:

https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@244 
PS1, Line 244: 7
  I don't know if it matters. "14 MHz / 17
MHz" may be good.
Done


https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@348 
PS1, Line 348: 		"Descr.", "BIOS", "ME", "GbE",
"Platf.", "DevExt", "BIOS2", "unknown",
  Dev*Exp*
Done


https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@348 
PS1, Line 348: ME
  Somewhere should be a hint that APL differs from other
platforms. It must not be here. […]
I've decided to leave it as is (if that can
get approval):
It never was flashrom's purpose to care about the flash
contents. Actually, I think "ME" is most honest. While it
doesn't contain all possible software running on the ME,
it is what the ME might boot from.


https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@452 
PS1, Line 452: 		msg_pdbg2("       FD   IFWI  TXE   n/a  Platf DevExt\n");
  Dev*Exp*
Done


https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@452 
PS1, Line 452: TXE
  This string is APL specific. […]
These are the
terms used in the "SPI and SMIP Guide", I would like to keep
it consistent.


https://review.coreboot.org/#/c/30995/1/ichspi.c 
File ichspi.c:

https://review.coreboot.org/#/c/30995/1/ichspi.c@1572 
PS1, Line 1572: 		"Gigabit Ethernet", "Platform Data", "Device
Extension",
  Device *Expansion*
Done



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/30995
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c464b5b3d151e6d28d5db96495fe874a0a45718
Gerrit-Change-Number: 30995
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 06 Jun 2019 14:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment