Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38667 )
Change subject: meson.build: Align config options with tabs
......................................................................
Patch Set 1:
Patch Set 1: Code-Review-1
Please don't.
This adds needless churn, breaks git blame and makes the formatting of the file inconsistent.
Well, git blame on this rather recent part of the code isn't too critical. What about the reordering of flashchips.c, which also broke git blame? In any case, one can checkout the parent of the offending commit and run git blame on that.
With regard to tabs, would this be better if done with spaces instead?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/38667
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idf02cdb57b67d86eec4981b9bd000b197175ec67
Gerrit-Change-Number: 38667
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006@gmx.net
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 02 Feb 2020 12:38:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment