Patch Set 1: Code-Review-1

Please don't.
This adds needless churn, breaks git blame and makes the formatting of the file inconsistent.

Well, git blame on this rather recent part of the code isn't too critical. What about the reordering of flashchips.c, which also broke git blame? In any case, one can checkout the parent of the offending commit and run git blame on that.

With regard to tabs, would this be better if done with spaces instead?

View Change

To view, visit change 38667. To unsubscribe, or for help writing mail filters, visit settings.