Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/38661 )
Change subject: 82802ab.c: Remove duplicated check ......................................................................
82802ab.c: Remove duplicated check
Change-Id: I5d511d7ec254bdbd9926e6d8efc308fb2339cb81 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/38661 Reviewed-by: Idwer Vollering vidwer@gmail.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Philippe Mathieu-Daudé f4bug@amsat.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M 82802ab.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Idwer Vollering: Looks good to me, approved Philippe Mathieu-Daudé: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved
diff --git a/82802ab.c b/82802ab.c index 281b66e..b485c11 100644 --- a/82802ab.c +++ b/82802ab.c @@ -89,9 +89,9 @@ chipaddr bios = flash->virtual_memory;
chip_writeb(flash, 0x70, bios); - if ((chip_readb(flash, bios) & 0x80) == 0) { // it's busy - while ((chip_readb(flash, bios) & 0x80) == 0) ; - } + + while ((chip_readb(flash, bios) & 0x80) == 0) // it's busy + ;
status = chip_readb(flash, bios);