Attention is currently required from: Simon Buhrow, Aarya, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )
Change subject: flashrom.c: Add functions for new erase selction algorithm ......................................................................
Patch Set 86:
(8 comments)
Patchset:
PS86: relatively minor stuff now, we can still iterate in tree however the more const correctness the better. The more expensive you can be with types the better it communicates your intentions of your code to the compiler - e.g., modifying a loop upper bound you intended to be const.
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/65844/comment/d94201de_4922fcfd PS86, Line 114: s `const`
https://review.coreboot.org/c/flashrom/+/65844/comment/2bd74227_c520ebbf PS86, Line 130: size_t num; delete
https://review.coreboot.org/c/flashrom/+/65844/comment/4565cf95_70abb9fd PS86, Line 133: ( `size_t num = 0;`
https://review.coreboot.org/c/flashrom/+/65844/comment/68295e89_cb982826 PS86, Line 165: const unsigned int `const size_t`?
https://review.coreboot.org/c/flashrom/+/65844/comment/8b486bf7_7f20a426 PS86, Line 166: unsigned int and this `size_t` too?
https://review.coreboot.org/c/flashrom/+/65844/comment/d39e3d42_f18e6113 PS86, Line 216: int `const int` ?
https://review.coreboot.org/c/flashrom/+/65844/comment/e15ee17e_8171ecc3 PS86, Line 217: int `const int` ?