Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37776 ) Change subject: Add -- to make clean ...................................................................... Patch Set 1: Code-Review-1 (1 comment)
Patch Set 1: Code-Review-1
Can you be more specific about how that file came into existence?
Although the `rm` man page agrees with your approach, I think we should not try to force `make clean` to work in this case since we can't be sure what's garbage and what isn't, aside from files we generated ourselves via `make`.
If flashrom's build system is outputting files like that then we should figure out why instead of masking the issue.
I'm also curious about the origins of that file. https://review.coreboot.org/c/flashrom/+/37776/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/37776/1//COMMIT_MSG@7 PS1, Line 7: Add -- to make clean Makefile: Add `--` to `rm` -- To view, visit https://review.coreboot.org/c/flashrom/+/37776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2517ffac975f3df75f706350a07f189a98a11b7c Gerrit-Change-Number: 37776 Gerrit-PatchSet: 1 Gerrit-Owner: Ryan O'Leary <ryanoleary@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 23 Dec 2019 21:40:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment