Change in flashrom[master]: Add -- to make clean

[Ryan O'Leary (Code Review)]

Ryan O'Leary has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/37776 )

Change subject: Add -- to make clean
......................................................................

Add -- to make clean

Somehow, I ended up with a file name "-c.d". I probably made it by
mistake. This change lets "make clean" be a bit more resilient to files
such as these.

Change-Id: I2517ffac975f3df75f706350a07f189a98a11b7c
Signed-off-by: Ryan O'Leary 
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/37776/1

diff --git a/Makefile b/Makefile
index 518d41b..fa66910 100644
--- a/Makefile
+++ b/Makefile
@@ -1129,7 +1129,7 @@
 # This includes all frontends and libflashrom.
 # We don't use EXEC_SUFFIX here because we want to clean everything.
 clean:
-	rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a *.o *.d $(PROGRAM).8 $(PROGRAM).8.html $(BUILD_DETAILS_FILE)
+	rm -f -- $(PROGRAM) $(PROGRAM).exe libflashrom.a *.o *.d $(PROGRAM).8 $(PROGRAM).8.html $(BUILD_DETAILS_FILE)
    @+$(MAKE) -C util/ich_descriptors_tool/ clean

distclean: clean

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37776 )

Change subject: Add -- to make clean
......................................................................

Patch Set 1: Code-Review+1

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37776 )

Change subject: Add -- to make clean
......................................................................

Patch Set 1: Code-Review-1

Can you be more specific about how that file came into existence?

Although the `rm` man page agrees with your approach, I think we should not try to force `make clean` to work in this case since we can't be sure what's garbage and what isn't, aside from files we generated ourselves via `make`.

If flashrom's build system is outputting files like that then we should figure out why instead of masking the issue.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37776 )

Change subject: Add -- to make clean
......................................................................

Patch Set 1: Code-Review-1

(1 comment)
> Patch Set 1: Code-Review-1
>
> Can you be more specific about how that file came into existence?
>
> Although the `rm` man page agrees with your approach, I think we should not try to force `make clean` to work in this case since we can't be sure what's garbage and what isn't, aside from files we generated ourselves via `make`.
>
> If flashrom's build system is outputting files like that then we should figure out why instead of masking the issue.

I'm also curious about the origins of that file.

https://review.coreboot.org/c/flashrom/+/37776/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/37776/1//COMMIT_MSG@7 
PS1, Line 7: Add -- to make clean
Makefile: Add `--` to `rm`

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37776 )

Change subject: Add -- to make clean
......................................................................

Patch Set 1: Code-Review+2

No matter where that file came from, we shouldn't produce invalid
`rm` invocations based on files lying around.

But please fix the commit summary. I was confused as well, thought
you wanted to delete a file called `--`, i.e. run `rm -f -- --`.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37776 )

Change subject: Add -- to make clean
......................................................................

Patch Set 1:

Clarification: My -1 is only about the commit message.

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37776 )

Change subject: Add -- to make clean
......................................................................

Patch Set 1: -Code-Review

I'm fine with merging this

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37776 )

Change subject: Add -- to make clean
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/flashrom/+/37776/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/37776/1//COMMIT_MSG@7 
PS1, Line 7: Add -- to make clean
> Makefile: Add `--` to `rm`

Or

Add -- to rm command to make it more resilient