Attention is currently required from: Angel Pons. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51967 )
Change subject: lspcon_i2c_spi: support a devpath option ......................................................................
Patch Set 3:
(4 comments)
File lspcon_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/51967/comment/67689049_f24a3d89 PS2, Line 457: __func__);
nit: `__func__` probably fits on the previous line
Done
https://review.coreboot.org/c/flashrom/+/51967/comment/b17fd475_96290503 PS2, Line 463: __func__);
nit: `__func__` most likely fits on the previous line
Done
https://review.coreboot.org/c/flashrom/+/51967/comment/1512b0d9_1d11c202 PS2, Line 489:
nit: replace 8 spaces with a tab
Done
https://review.coreboot.org/c/flashrom/+/51967/comment/fb3374fa_ec8dea86 PS2, Line 492: } else if (device_path != NULL) {
The first two cases are error paths that return an error, whereas the last two cases are the "normal […]
Done