Change in flashrom[master]: lspcon_i2c_spi: support a devpath option
Attention is currently required from: Angel Pons. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51967 ) Change subject: lspcon_i2c_spi: support a devpath option ...................................................................... Patch Set 3: (4 comments) File lspcon_i2c_spi.c: https://review.coreboot.org/c/flashrom/+/51967/comment/67689049_f24a3d89 PS2, Line 457: __func__);
nit: `__func__` probably fits on the previous line Done
https://review.coreboot.org/c/flashrom/+/51967/comment/b17fd475_96290503 PS2, Line 463: __func__);
nit: `__func__` most likely fits on the previous line Done
https://review.coreboot.org/c/flashrom/+/51967/comment/1512b0d9_1d11c202 PS2, Line 489:
nit: replace 8 spaces with a tab Done
https://review.coreboot.org/c/flashrom/+/51967/comment/fb3374fa_ec8dea86 PS2, Line 492: } else if (device_path != NULL) {
The first two cases are error paths that return an error, whereas the last two cases are the "normal […] Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/51967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2adf8a307b9205ce5e5804a6c3e22f19d0c34c9 Gerrit-Change-Number: 51967 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Marheine <pmarheine@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Daniel Campello <campello@chromium.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Mon, 12 Apr 2021 00:18:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
participants (1)
-
Peter Marheine (Code Review)