Attention is currently required from: Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81606?usp=email ) Change subject: Make sleep threshold for delays configurable ...................................................................... Patch Set 2: (3 comments) File Makefile: https://review.coreboot.org/c/flashrom/+/81606/comment/5542b2ff_ed5f1926 : PS2, Line 545: CONFIG_DELAY_MINIMUM_SLEEP_US ?= 100000 meson_options.txt has a good desciption on this, maybe add here as a comment File tests/udelay.c: https://review.coreboot.org/c/flashrom/+/81606/comment/88bd7527_801cb293 : PS2, Line 45: udelay_test_short For completeness, it would be good to build and run unit tests with few different settings: CONFIG_DELAY_MINIMUM_SLEEP_US not set (will be default) CONFIG_DELAY_MINIMUM_SLEEP_US smaller / larger than default CONFIG_DELAY_MINIMUM_SLEEP_US is 1 (test is expected to be skipped) and maybe you've done all that already, but then if you can add this as testing info in commit message, that would be great, thank you! https://review.coreboot.org/c/flashrom/+/81606/comment/1f42556c_089ad6c0 : PS2, Line 52: if (delay_us >= CONFIG_DELAY_MINIMUM_SLEEP_US) why this condition is needed? if CONFIG_DELAY_MINIMUM_SLEEP_US is set to 200 why can't we run the test for 199 ? -- To view, visit https://review.coreboot.org/c/flashrom/+/81606?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ida96e0816ac914ed69d6fd82ad90ebe89cdef1cc Gerrit-Change-Number: 81606 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Marheine <pmarheine@chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Thomas Heijligen <src@posteo.de> Gerrit-Attention: Peter Marheine <pmarheine@chromium.org> Gerrit-Comment-Date: Fri, 26 Apr 2024 07:47:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment