- flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[master]: meson.build: Uplift minimum Meson version to 0.56.0
by Anastasia Klimchuk (Code Review) 14 Sep '23

14 Sep '23

Attention is currently required from: Anton Samsonov, Peter Marheine, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77779?usp=email ) Change subject: meson.build: Uplift minimum Meson version to 0.56.0 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I recalled there was a moment when we tried to upgrade the version but then reverted back. I found the patch CB:73361 but from the comments it seems that 0.56.0 should be fine. Also indeed substring() was only introduced in 0.56 From Jenkins logs I see that 1.0 is installed on server, so that's even higher. I hope I am not missing anything? -- To view, visit https://review.coreboot.org/c/flashrom/+/77779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I53c6c42c27a58734742e3dce3cdbde4c65b89a90 Gerrit-Change-Number: 77779 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 14 Sep 2023 09:20:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flashrom_tester: Align WP output format with upstream
by Edward O'Callaghan (Code Review) 14 Sep '23

14 Sep '23

Attention is currently required from: Evan Benn, Scott Chao. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77887?usp=email ) Change subject: flashrom_tester: Align WP output format with upstream ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Gerrit-Change-Number: 77887 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Evan Benn <evanbenn(a)gmail.com> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Thu, 14 Sep 2023 05:41:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flashrom_tester: Align WP output format with upstream
by Scott Chao (Code Review) 14 Sep '23

14 Sep '23

Attention is currently required from: Evan Benn. Hello Evan Benn, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/77887?usp=email to look at the new patch set (#2). Change subject: flashrom_tester: Align WP output format with upstream ...................................................................... flashrom_tester: Align WP output format with upstream After WP output format changed, the flashrom_tester will always read software write protect is disabled. BUG=b:300300436 TEST=Verify on flashrom_tester Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Signed-off-by: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> --- M util/flashrom_tester/flashrom/src/cmd.rs 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/77887/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Gerrit-Change-Number: 77887 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Attention: Evan Benn <evanbenn(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[master]: flashrom_tester: Align WP output format with upstream
by Scott Chao (Code Review) 14 Sep '23

14 Sep '23

Scott Chao has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77887?usp=email ) Change subject: flashrom_tester: Align WP output format with upstream ...................................................................... flashrom_tester: Align WP output format with upstream After WP output format changed, the flashrom_tester will always read software write protect is disabled. BUG=b: TEST=Verify on flashrom_tester Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Signed-off-by: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> --- M util/flashrom_tester/flashrom/src/cmd.rs 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/77887/1 diff --git a/util/flashrom_tester/flashrom/src/cmd.rs b/util/flashrom_tester/flashrom/src/cmd.rs index 1f13a8e..9e66fe2 100644 --- a/util/flashrom_tester/flashrom/src/cmd.rs +++ b/util/flashrom_tester/flashrom/src/cmd.rs @@ -194,6 +194,7 @@ fn wp_status(&self, en: bool) -> Result<bool, FlashromError> { let status = if en { "en" } else { "dis" }; + let protection_mode = if en { "hardware" } else { "disable" }; info!("See if chip write protect is {}abled", status); let opts = FlashromOpt { @@ -205,7 +206,7 @@ }; let (stdout, _) = self.dispatch(opts, "wp_status")?; - let s = std::format!("write protect is {}abled", status); + let s = std::format!("Protection mode: {}", protection_mode); Ok(stdout.contains(&s)) } -- To view, visit https://review.coreboot.org/c/flashrom/+/77887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I755891e0d8b5857650febe08c2094733cf1f4c79 Gerrit-Change-Number: 77887 Gerrit-PatchSet: 1 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: flashchips: Add support for MXIC MX25U25643G
by Anastasia Klimchuk (Code Review) 14 Sep '23

14 Sep '23

Attention is currently required from: Name of user not set #1005084, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76853?usp=email ) Change subject: flashchips: Add support for MXIC MX25U25643G ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Thank you! it was a very good idea to update the definition of existing chip if they are almost the same. -- To view, visit https://review.coreboot.org/c/flashrom/+/76853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Gerrit-Change-Number: 76853 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1005084 Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Name of user not set #1005084 Gerrit-Comment-Date: Thu, 14 Sep 2023 00:09:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: add definition of the XT25F02E SPI NOR flash
by Peter Marheine (Code Review) 13 Sep '23

13 Sep '23

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Neil Armstrong, Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50263?usp=email ) Change subject: flashchips: add definition of the XT25F02E SPI NOR flash ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/50263?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I295633c448c05520e4a6aa09c08bd7c9f2346d54 Gerrit-Change-Number: 50263 Gerrit-PatchSet: 5 Gerrit-Owner: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Neil Armstrong <narmstrong(a)baylibre.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 13 Sep 2023 04:00:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: meson.build: Uplift minimum Meson version to 0.56.0
by Anton Samsonov (Code Review) 12 Sep '23

12 Sep '23

Anton Samsonov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77779?usp=email ) Change subject: meson.build: Uplift minimum Meson version to 0.56.0 ...................................................................... meson.build: Uplift minimum Meson version to 0.56.0 Since doc/meson.build uses `str.substring()` introduced in Meson 0.56.0, the root meson.build should be updated from 0.53.0. Change-Id: I53c6c42c27a58734742e3dce3cdbde4c65b89a90 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M meson.build 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/77779/1 diff --git a/meson.build b/meson.build index 77d941e..c85fdf4 100644 --- a/meson.build +++ b/meson.build @@ -1,7 +1,7 @@ project('flashromutils', 'c', version : run_command('cat', 'VERSION', check: true).stdout().strip(), license : 'GPL-2.0', - meson_version : '>=0.53.0', + meson_version : '>=0.56.0', default_options : [ 'warning_level=2', 'c_std=c99', -- To view, visit https://review.coreboot.org/c/flashrom/+/77779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I53c6c42c27a58734742e3dce3cdbde4c65b89a90 Gerrit-Change-Number: 77779 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: Makefile,meson.build: Add support for Sphinx 3.x
by Anton Samsonov (Code Review) 12 Sep '23

12 Sep '23

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Thomas Heijligen. Hello Anastasia Klimchuk, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/77778?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Makefile,meson.build: Add support for Sphinx 3.x ...................................................................... Makefile,meson.build: Add support for Sphinx 3.x Prior to version 4.0, `sphinx-build` outputs man pages to "8" directory instead of "man8" (for details, see their GitHub issues 7996 and 9217). Current solution is to rename "8" to "man8" after documentation build. That enables successful build and installation, as well as dependency tracking at build-system level, but not on `sphinx-build` own level upon which `meson` build relies. Change-Id: I9cd280551a1ba4d17edb2e857d56f80431b61e1b Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M Makefile M doc/meson.build A doc/sphinx-wrapper.sh 3 files changed, 40 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/77778/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77778?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cd280551a1ba4d17edb2e857d56f80431b61e1b Gerrit-Change-Number: 77778 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: Makefile,meson.build: Add support for Sphinx 3.x
by Anton Samsonov (Code Review) 12 Sep '23

12 Sep '23

Anton Samsonov has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/77778?usp=email ) Change subject: Makefile,meson.build: Add support for Sphinx 3.x ...................................................................... Makefile,meson.build: Add support for Sphinx 3.x Prior to version 4.0, `sphinx-build` outputs man pages to "8" directory instead of "man8" (for details, see their GitHub issues 7996 and 9217). Current solution is to rename "8" to "man8" after documentation is build. That enables successful build and installation, as well as dependency tracking at build-system level, but not on `sphinx-build` own level upon which `meson` build relies. Change-Id: I9cd280551a1ba4d17edb2e857d56f80431b61e1b Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M Makefile M doc/meson.build A doc/sphinx-wrapper.sh 3 files changed, 40 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/77778/1 diff --git a/Makefile b/Makefile index bf01d0f..3992ee3 100644 --- a/Makefile +++ b/Makefile @@ -227,6 +227,10 @@ CONFIG_LIBPCI_CFLAGS := $(call dependency_cflags, libpci) CONFIG_LIBPCI_LDFLAGS := $(call dependency_ldflags, libpci) +CONFIG_SPHINXBUILD_VERSION := +CONFIG_SPHINXBUILD_MAJOR := 0 + + # Determine the destination OS, architecture and endian # IMPORTANT: The following lines must be placed before TARGET_OS, ARCH or ENDIAN # is ever used (of course), but should come after any lines setting CC because @@ -947,6 +951,11 @@ OBJS = $(CHIP_OBJS) $(PROGRAMMER_OBJS) $(LIB_OBJS) +ifeq ($(HAS_SPHINXBUILD), yes) +override CONFIG_SPHINXBUILD_VERSION := $(shell $(SPHINXBUILD) --version | cut -d' ' -f2 ) +override CONFIG_SPHINXBUILD_MAJOR := $(shell echo "$(CONFIG_SPHINXBUILD_VERSION)" | cut -d'.' -f1 ) +endif + all: $(PROGRAM)$(EXEC_SUFFIX) $(call has_dependency, $(HAS_SPHINXBUILD), man8/$(PROGRAM).8) ifeq ($(ARCH), x86) @@ -1009,7 +1018,7 @@ echo "The following features are unavailable on your machine: $(UNSUPPORTED_FEATURES)" \ exit 1; \ fi - @echo "Checking for program \"sphinx-build\": $(HAS_SPHINXBUILD)" + @echo "Checking for program \"sphinx-build\": $(HAS_SPHINXBUILD) $(CONFIG_SPHINXBUILD_VERSION)" %.o: %.c | config $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_FLAGS) -D'FLASHROM_VERSION=$(VERSION)' -o $@ -c $< @@ -1024,6 +1033,12 @@ man8/$(PROGRAM).8: doc/* @if [ "$(HAS_SPHINXBUILD)" = "yes" ]; then \ $(SPHINXBUILD) -Drelease=$(VERSION) -b man doc .; \ + if [ "$(CONFIG_SPHINXBUILD_MAJOR)" -lt 4 ]; then \ + if [ -d 8 ]; then \ + rm -rf man8; \ + mv 8 man8; \ + fi \ + fi \ else \ echo "$(SPHINXBUILD) not found. Can't build man-page"; \ exit 1; \ diff --git a/doc/meson.build b/doc/meson.build index aca73d8..f81d991 100644 --- a/doc/meson.build +++ b/doc/meson.build @@ -1,5 +1,6 @@ sphinx = find_program('sphinx-build', native : true, required : get_option('man-pages').enabled() or get_option('documentation').enabled()) +sphinx_wrapper = '@CURRENT_SOURCE_DIR@/sphinx-wrapper.sh' man_pages = [ 'flashrom.8' @@ -14,7 +15,7 @@ custom_target( 'man-pages', - command : [sphinx, '-b', 'man', '-q', '-d', '@PRIVATE_DIR@', '-Drelease=' + flashrom_version,'@CURRENT_SOURCE_DIR@', '@OUTDIR@'], + command : [sphinx_wrapper, '@OUTDIR@', ' '.join(man_outputs), sphinx, '-b', 'man', '-q', '-d', '@PRIVATE_DIR@', '-Drelease=' + flashrom_version, '@CURRENT_SOURCE_DIR@', '@OUTDIR@'], build_always_stale : true, # sphinx handles rebuilds output : man_outputs, install : true, diff --git a/doc/sphinx-wrapper.sh b/doc/sphinx-wrapper.sh new file mode 100755 index 0000000..b0ee33c --- /dev/null +++ b/doc/sphinx-wrapper.sh @@ -0,0 +1,22 @@ +#!/bin/sh + +OUTPUT_HOME="$1" +MAN_OUTPUTS="$2" +SPHINXBUILD="$3" +shift 3 + +"${SPHINXBUILD}" "$@" || exit $? + +SPHINXBUILD_MAJOR="$("${SPHINXBUILD}" --version | cut -d' ' -f2 | cut -d'.' -f1)" +if [ "${SPHINXBUILD_MAJOR}" -ge 4 ]; then + exit 0 +fi + +for MAN_OUTPUT in ${MAN_OUTPUTS}; do + PATH_TARGET="${OUTPUT_HOME}/${MAN_OUTPUT}" + PATH_ACTUAL="${OUTPUT_HOME}/${MAN_OUTPUT#man}" + if [ -d "${PATH_ACTUAL}" ]; then + rm -rf "${PATH_TARGET}" + mv "${PATH_ACTUAL}" "${PATH_TARGET}" + fi +done -- To view, visit https://review.coreboot.org/c/flashrom/+/77778?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9cd280551a1ba4d17edb2e857d56f80431b61e1b Gerrit-Change-Number: 77778 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[master]: flashchips: Add support for MXIC MX25U25643G
by Name of user not set (Code Review) 12 Sep '23

12 Sep '23

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Name of user not set #1005084 has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76853?usp=email ) Change subject: flashchips: Add support for MXIC MX25U25643G ...................................................................... Patch Set 3: (9 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/76853/comment/ae7c9169_e524153f : PS1, Line 7: MX2525643G > Let's use exact name MX25U25643G , can you please update? Done https://review.coreboot.org/c/flashrom/+/76853/comment/6624e780_336469ef : PS1, Line 8: MX2525635F > Same here, probably MX25U25635F Done https://review.coreboot.org/c/flashrom/+/76853/comment/2155a610_1b44321a : PS1, Line 10: Tested: read, write and erase. > Could you please add info which programmer you ran? Done https://review.coreboot.org/c/flashrom/+/76853/comment/3a10c1c4_e7ffdd15 : PS1, Line 12: Datasheet is available at the following URL: : https://www.mxic.com.tw/Lists/Datasheet/Attachments/8766/MX2525643G,%201.8V… > You need to update the link (the new one you gave me in the comment works) Done File flashchips.c: https://review.coreboot.org/c/flashrom/+/76853/comment/4938e3cb_adb2727c : PS1, Line 10094: MACRONIX_MX25U25643G > After you fix my other comment about id, you will change this to MACRONIX_MX25U25635F Done https://review.coreboot.org/c/flashrom/+/76853/comment/1891de3a_eef097c3 : PS1, Line 10104: { : .eraseblocks = { {4 * 1024, 8192} }, : .block_erase = SPI_BLOCK_ERASE_21, : }, > Maybe I am missing something, I don't see this in the datasheet. […] I compared the two chips MX25U25635F and MX25U25635F, and the two chips used almost the same command set. In 4 Byte Address Command Set, 21h for sector erase. https://review.coreboot.org/c/flashrom/+/76853/comment/9f5854f4_47ae2140 : PS1, Line 10113: { : .eraseblocks = { {32 * 1024, 1024} }, : .block_erase = SPI_BLOCK_ERASE_52, : }, > same Done https://review.coreboot.org/c/flashrom/+/76853/comment/60472063_6504f289 : PS1, Line 10117: .eraseblocks = { {64 * 1024, 512} }, : .block_erase = SPI_BLOCK_ERASE_DC, : }, { > same Done File include/flashchips.h: https://review.coreboot.org/c/flashrom/+/76853/comment/bb450622_58b47add : PS1, Line 530: #define MACRONIX_MX25U25643G 0x2539 > Don't add the same id, add a comment on existing id (MACRONIX_MX25U25635F), like that: […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/76853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Gerrit-Change-Number: 76853 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1005084 Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 12 Sep 2023 09:20:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit