- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: erasure_layout: Fix double invocation of erasers
by Anastasia Klimchuk (Code Review) 12 Sep '23

12 Sep '23

Attention is currently required from: Aarya, Alexander Goncharov, Sam McNally. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77747?usp=email ) Change subject: erasure_layout: Fix double invocation of erasers ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Hopefully it will fix this [issue](https://ticket.coreboot.org/issues/494). […] Oh I missed that issue, sorry :(( I assigned to myself so that it's not missed. -- To view, visit https://review.coreboot.org/c/flashrom/+/77747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I92351eba0fd29114ce98b4a839358e92d176af28 Gerrit-Change-Number: 77747 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Tue, 12 Sep 2023 09:07:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: erasure_layout: Fix double invocation of erasers
by Alexander Goncharov (Code Review) 12 Sep '23

12 Sep '23

Attention is currently required from: Aarya, Anastasia Klimchuk, Sam McNally. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77747?usp=email ) Change subject: erasure_layout: Fix double invocation of erasers ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Hopefully it will fix this [issue](https://ticket.coreboot.org/issues/494). But I will be able to check it on my hardware in a few days, so I will mark this comment as unresolved until then. -- To view, visit https://review.coreboot.org/c/flashrom/+/77747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I92351eba0fd29114ce98b4a839358e92d176af28 Gerrit-Change-Number: 77747 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Sep 2023 07:27:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[master]: flashchips: Add support for MXIC MX25U25643G
by Name of user not set (Code Review) 12 Sep '23

12 Sep '23

Attention is currently required from: Name of user not set #1005084, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/76853?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: flashchips: Add support for MXIC MX25U25643G ...................................................................... flashchips: Add support for MXIC MX25U25643G It is similar to the MX25U25635F and shares its RDID. Tested by ch341a programmer : read, write and erase. Datasheet is available at the following URL: https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Signed-off-by: xianzheng <xianzheng(a)mxic.com.cn> --- M flashchips.c M include/flashchips.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/76853/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/76853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Gerrit-Change-Number: 76853 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1005084 Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Name of user not set #1005084 Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashchips: Add support for MXIC MX25U25643G
by Name of user not set (Code Review) 12 Sep '23

12 Sep '23

Attention is currently required from: Name of user not set #1005084. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/76853?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add support for MXIC MX25U25643G ...................................................................... flashchips: Add support for MXIC MX25U25643G It is similar to the MX25U25635F and shares its RDID. Tested by ch341a programmer : read, write and erase. Datasheet is available at the following URL: https://www.mxic.com.tw/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spe… Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Signed-off-by: xianzheng <xianzheng(a)mxic.com.cn> --- M flashchips.c M include/flashchips.h 2 files changed, 52 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/76853/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/76853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie04a5e2325aab94bffb276675be3fa4a88c6e134 Gerrit-Change-Number: 76853 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1005084 Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Name of user not set #1005084 Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: erasure_layout: Fix double invocation of erasers
by Edward O'Callaghan (Code Review) 12 Sep '23

12 Sep '23

Attention is currently required from: Aarya, Anastasia Klimchuk, Sam McNally. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77747?usp=email ) Change subject: erasure_layout: Fix double invocation of erasers ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I believe Sam had something to say about the double erasefn() call at some point. -- To view, visit https://review.coreboot.org/c/flashrom/+/77747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I92351eba0fd29114ce98b4a839358e92d176af28 Gerrit-Change-Number: 77747 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Sep 2023 01:37:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Remove dependency on C23 __has_include()
by Anton Samsonov (Code Review) 11 Sep '23

11 Sep '23

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Anton Samsonov, Thomas Heijligen. Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77089?usp=email ) Change subject: Remove dependency on C23 __has_include() ...................................................................... Patch Set 3: (4 comments) Patchset: PS1: > Appreciate your explanation. I don't think there's any point in describing it in the commit message. […] Done PS1: > I would avoid introducing new pre-processor conditionals, because we are planning to go in the oppos […] I totally agree with all your and Alexander's propositions, however have no knowledge of how to test for header presence without preprocessor conditionals — whether it is C23's `__has_include()` check or autoconf's `HAVE_..._H` macro. I went for the latter and tried to adapt not only the Makefile (which I only care about currently), but meson.build as well (which I am not familiar with). While meson also succeeds on both my test systems with different software versions, it fails here on Jenkins, and I have no idea why. File include/cli_classic.h: https://review.coreboot.org/c/flashrom/+/77089/comment/04f51cfa_661cc65d : PS1, Line 21: #if !defined(__has_include) && (__STDC_VERSION__ < 202300L) : #include <getopt.h> : #define HAVE_GETOPT_H 1 > If we cannot identify whether this header file exists on the user's system, then let's assume it doe […] Done https://review.coreboot.org/c/flashrom/+/77089/comment/07f97a7d_d7ff49a5 : PS1, Line 18: #if HAVE_GETOPT_H : #include <getopt.h> : #elif !defined(HAVE_GETOPT_H) : #if !defined(__has_include) && (__STDC_VERSION__ < 202300L) : #include <getopt.h> : #define HAVE_GETOPT_H 1 : #elif __has_include(<getopt.h>) : #include <getopt.h> : #define HAVE_GETOPT_H 1 : #else : #define HAVE_GETOPT_H 0 : #endif /* __has_include() */ : #endif /* HAVE_GETOPT_H */ : : #if !HAVE_GETOPT_H > Sorry it took me some time to get to this patch. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/77089?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6 Gerrit-Change-Number: 77089 Gerrit-PatchSet: 3 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 11 Sep 2023 15:51:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anton Samsonov <avscomputing(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Remove dependency on C23 __has_include()
by Anton Samsonov (Code Review) 11 Sep '23

11 Sep '23

Attention is currently required from: Alexander Goncharov, Anton Samsonov, Anton Samsonov, Thomas Heijligen. Hello Alexander Goncharov, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/77089?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Remove dependency on C23 __has_include() ...................................................................... Remove dependency on C23 __has_include() Use build system to check header presence: * getopt.h (from include/cli_classic.h) * pciutils/pci.h (from include/platform/pci.h) Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M Makefile A Makefile.d/getopt_test.c A Makefile.d/pciutils_test.c M include/cli_classic.h M include/platform/pci.h M meson.build 6 files changed, 46 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/77089/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/77089?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6 Gerrit-Change-Number: 77089 Gerrit-PatchSet: 3 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: Remove dependency on C23 __has_include()
by Anton Samsonov (Code Review) 11 Sep '23

11 Sep '23

Attention is currently required from: Alexander Goncharov, Anton Samsonov, Anton Samsonov. Hello Alexander Goncharov, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/77089?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Remove dependency on C23 __has_include() ...................................................................... Remove dependency on C23 __has_include() Use build system to check header presence: * getopt.h (from include/cli_classic.h) * pciutils/pci.h (from include/platform/pci.h) Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M Makefile M include/cli_classic.h M include/platform/pci.h M meson.build 4 files changed, 30 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/77089/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/77089?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic544963ffd29626ae0a21bdddb1c78850cc43ec6 Gerrit-Change-Number: 77089 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[L] Change in flashrom[master]: tests: Unit tests for erase function selection algo
by Anastasia Klimchuk (Code Review) 11 Sep '23

11 Sep '23

Attention is currently required from: Aarya, Edward O'Callaghan, Nikolai Artemiev, Simon Buhrow, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67535?usp=email ) Change subject: tests: Unit tests for erase function selection algo ...................................................................... Patch Set 12: (7 comments) File tests/erase_func_algo.c: https://review.coreboot.org/c/flashrom/+/67535/comment/0dd3ff16_b0c85758 : PS3, Line 238: void **state > `g_state` should probably be passed in here. I will check cmocka docs how to do it, keep this unresolved for now. https://review.coreboot.org/c/flashrom/+/67535/comment/980322b7_b84ad064 : PS3, Line 282: uint8_t *const newcontents = malloc(MIN_BUF_SIZE); > `uint8_t newcontents[MIN_BUF_SIZE];` Done https://review.coreboot.org/c/flashrom/+/67535/comment/4b751c86_d6323045 : PS3, Line 291: n > `&n` Done https://review.coreboot.org/c/flashrom/+/67535/comment/00fcf985_b2dfe629 : PS3, Line 294: n > `&n` Done https://review.coreboot.org/c/flashrom/+/67535/comment/c6e8a2a4_36d8898e : PS3, Line 313: : free(newcontents); > drops lines 313&&314. Done File tests/erase_func_algo.c: https://review.coreboot.org/c/flashrom/+/67535/comment/6a05e0ce_4789b28f : PS5, Line 37: uint8_t buf[MOCK_CHIP_SIZE]; /* Contents of the mock chip. */ > Can buf be moved into struct all_state? Yes! I did it. But I wanted to clarify about: > Then the test_case struct will only contain test parameters and can be const. What exactly do you mean? https://review.coreboot.org/c/flashrom/+/67535/comment/4a3060f6_79358ac8 : PS5, Line 501: memcmp > This should probably be`!memcmp(... […] Yes, makes sense. I changed so that now all three chip_erased eraseblocks_in_order eraseblocks_invocations mean what their names mean. However `!` has now moved further below, because I still need the final result to be 0 for success. But hope that's fine. -- To view, visit https://review.coreboot.org/c/flashrom/+/67535?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7 Gerrit-Change-Number: 67535 Gerrit-PatchSet: 12 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 11 Sep 2023 12:20:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: tests: Unit tests for erase function selection algo
by Anastasia Klimchuk (Code Review) 11 Sep '23

11 Sep '23

Attention is currently required from: Aarya, Simon Buhrow, Thomas Heijligen. Hello Aarya, Edward O'Callaghan, Simon Buhrow, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67535?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: tests: Unit tests for erase function selection algo ...................................................................... tests: Unit tests for erase function selection algo The test checks that algorithm for erase functions selection works and there are no regressions. Specifically, test contains a number of test cases (14 at the time of writing, but more can be added). Each case initialises a given initial state of the memory for the mock chip, and layout regions on the chip, and then performs erase and write operations. At the end of operation, test asserts the following: - the state of mock chip memory is as expected, i.e. properly erased or written - erase blocks are invoked in expected order and expected number of them - chip operation (erase or write) returned 0. Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- A tests/erase_func_algo.c M tests/meson.build M tests/tests.c M tests/tests.h 4 files changed, 609 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/67535/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/67535?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7 Gerrit-Change-Number: 67535 Gerrit-PatchSet: 12 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit