- flashrom-gerrit - mail.coreboot.org

Change in flashrom[refs/meta/config]: Test
by Nico Huber (Code Review) 11 Nov '17

11 Nov '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22433 Change subject: Test ...................................................................... Test Change-Id: I1eed7d5925347caa2f4ba5e1c7bd4705c95bf876 --- M project.config 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/33/22433/1 diff --git a/project.config b/project.config index f9dbbc1..2c0ce1a 100644 --- a/project.config +++ b/project.config @@ -8,6 +8,7 @@ exclusiveGroupPermissions = createTag createSignedTag createTag = group flashrom developers createSignedTag = group flashrom developers + push = group flashrom developers [label "Code-Review"] function = MaxWithBlock -- To view, visit https://review.coreboot.org/22433 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: newchange Gerrit-Change-Id: I1eed7d5925347caa2f4ba5e1c7bd4705c95bf876 Gerrit-Change-Number: 22433 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: spi_master: Introduce SPI_MASTER_4BA feature flags
by Nico Huber (Code Review) 11 Nov '17

11 Nov '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22421 ) Change subject: spi_master: Introduce SPI_MASTER_4BA feature flags ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/22421/4//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22421/4//COMMIT_MSG@17 PS4, Line 17: modes. Hmmm, it's a little more subtle. There is the case where the programmer can't handle 4BAs, but the extended address register should work (e.g. ichspi). -- To view, visit https://review.coreboot.org/22421 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c Gerrit-Change-Number: 22421 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 11 Nov 2017 12:16:08 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[master]: [WIP] flashchips: Revise all 4BA chips
by build bot (Jenkins) (Code Review) 11 Nov '17

11 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22423 ) Change subject: [WIP] flashchips: Revise all 4BA chips ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/754/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/864/ : SUCCESS -- To view, visit https://review.coreboot.org/22423 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0598496ee7058e3b170684d366f58e4014e0e871 Gerrit-Change-Number: 22423 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 10 Nov 2017 22:27:10 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: spi_master: Introduce SPI_MASTER_4BA feature flags
by build bot (Jenkins) (Code Review) 11 Nov '17

11 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22421 ) Change subject: spi_master: Introduce SPI_MASTER_4BA feature flags ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/753/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/863/ : SUCCESS -- To view, visit https://review.coreboot.org/22421 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c Gerrit-Change-Number: 22421 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 10 Nov 2017 22:27:04 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: spi25: Revise decision when to enter/exit 4BA mode
by build bot (Jenkins) (Code Review) 11 Nov '17

11 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22422 ) Change subject: spi25: Revise decision when to enter/exit 4BA mode ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/752/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/862/ : SUCCESS -- To view, visit https://review.coreboot.org/22422 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I877fe817f801fc54bd0ee2ce4e3ead324cbb3673 Gerrit-Change-Number: 22422 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 10 Nov 2017 22:26:58 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: [WIP] flashchips: Revise all 4BA chips
by Nico Huber (Code Review) 11 Nov '17

11 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22423 to look at the new patch set (#2). Change subject: [WIP] flashchips: Revise all 4BA chips ...................................................................... [WIP] flashchips: Revise all 4BA chips Change-Id: I0598496ee7058e3b170684d366f58e4014e0e871 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flash.h M flashchips.c 2 files changed, 50 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/22423/2 -- To view, visit https://review.coreboot.org/22423 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0598496ee7058e3b170684d366f58e4014e0e871 Gerrit-Change-Number: 22423 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: spi_master: Introduce SPI_MASTER_4BA feature flags
by Nico Huber (Code Review) 11 Nov '17

11 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22421 to look at the new patch set (#4). Change subject: spi_master: Introduce SPI_MASTER_4BA feature flags ...................................................................... spi_master: Introduce SPI_MASTER_4BA feature flags Add a feature flag SPI_MASTER_4BA to `struct spi_master` that advertises programmer-side support for 4-byte addresses in generic commands (and read/write commands if the master uses the default implementations). Set it for all masters that handle commands address-agnostic. Another feature flag SPI_MASTER_4BA_STATEFUL tells us that the program- mer keeps the flash chip powered between commands, i.e. the flash keeps its volatile state. This is needed to decide if we can use stateful 4BA modes. Don't prefer native 4BA instructions if the master doesn't support them. Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M bitbang_spi.c M buspirate_spi.c M ch341a_spi.c M dummyflasher.c M ft2232_spi.c M linux_spi.c M programmer.h M serprog.c M spi25.c 9 files changed, 34 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/22421/4 -- To view, visit https://review.coreboot.org/22421 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c Gerrit-Change-Number: 22421 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: spi25: Revise decision when to enter/exit 4BA mode
by build bot (Jenkins) (Code Review) 11 Nov '17

11 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22422 ) Change subject: spi25: Revise decision when to enter/exit 4BA mode ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/751/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/861/ : SUCCESS -- To view, visit https://review.coreboot.org/22422 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I877fe817f801fc54bd0ee2ce4e3ead324cbb3673 Gerrit-Change-Number: 22422 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 10 Nov 2017 22:16:05 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: spi_master: Introduce SPI_MASTER_4BA feature flags
by build bot (Jenkins) (Code Review) 11 Nov '17

11 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22421 ) Change subject: spi_master: Introduce SPI_MASTER_4BA feature flags ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/749/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/859/ : SUCCESS -- To view, visit https://review.coreboot.org/22421 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c Gerrit-Change-Number: 22421 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 10 Nov 2017 22:15:53 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: [WIP] flashchips: Revise all 4BA chips
by build bot (Jenkins) (Code Review) 11 Nov '17

11 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22423 ) Change subject: [WIP] flashchips: Revise all 4BA chips ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/750/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/860/ : SUCCESS -- To view, visit https://review.coreboot.org/22423 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0598496ee7058e3b170684d366f58e4014e0e871 Gerrit-Change-Number: 22423 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 10 Nov 2017 22:15:50 +0000 Gerrit-HasComments: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit