Urja Rannikko has posted comments on this change. ( https://review.coreboot.org/20250 )
Change subject: fixup of "Kill doit()"
......................................................................
Patch Set 1:
(re: the message, yeah you could but that wasnt the obvious workflow, actually I was very confused...)
Re: the guards, then you'd need to build internal.o always (since Makefile doesnt build it if no CONFIG_INTERNAL), and include an useless piece of .bss in the binary. You dislike guards that much?
--
To view, visit https://review.coreboot.org/20250
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9e715f09ef934bc36221b3e72c578ae96e0a3af
Gerrit-Change-Number: 20250
Gerrit-PatchSet: 1
Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 17 Jun 2017 10:50:53 +0000
Gerrit-HasComments: No
Nico Huber has posted comments on this change. ( https://review.coreboot.org/20250 )
Change subject: fixup of "Kill doit()"
......................................................................
Patch Set 1:
(1 comment)
Well, you can fix up the commit message after you got your Change-Id...
Hmmm, I used this once, don't remember any trouble though. Maybe I used
a different commit-msg hook, dunno.
https://review.coreboot.org/#/c/20250/1/cli_classic.c
File cli_classic.c:
https://review.coreboot.org/#/c/20250/1/cli_classic.c@556
PS1, Line 556: #if CONFIG_INTERNAL == 1
Ugh, guards...
How about moving the `force_boardmismatch` declaration and definition
out of their respective guards?
--
To view, visit https://review.coreboot.org/20250
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9e715f09ef934bc36221b3e72c578ae96e0a3af
Gerrit-Change-Number: 20250
Gerrit-PatchSet: 1
Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 17 Jun 2017 10:31:33 +0000
Gerrit-HasComments: Yes
Hello Stefan Tauner, David Hendricks, Paul Menzel, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/20223
to look at the new patch set (#4).
Change subject: Enable continuous SPI reads
......................................................................
Enable continuous SPI reads
Previous unnecessary page-by-page reading is repurposed to
read by big naturally aligned areas (now chip size limited
to 16MB for future-proofing of 4 byte addressed multi-die chips)
and serprog hack for continuous reads is removed.
Change-Id: Iadf909c9216578b1c5dacd4c4991bb436e32edc9
Signed-off-by: Urja Rannikko <urjaman(a)gmail.com>
---
M serprog.c
M spi25.c
2 files changed, 15 insertions(+), 35 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/20223/4
--
To view, visit https://review.coreboot.org/20223
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iadf909c9216578b1c5dacd4c4991bb436e32edc9
Gerrit-Change-Number: 20223
Gerrit-PatchSet: 4
Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Urja Rannikko has posted comments on this change. ( https://review.coreboot.org/20250 )
Change subject: fixup of "Kill doit()"
......................................................................
Patch Set 1:
Okay so this is my attempt at following the developer guidelines for fixups, but on gerrit.
The commit-msg hook doesnt give a Change-Id if the name has "fixup!" in it, which seems like that was meant for avoiding pushing fixes that were supposed to be rebased locally, whereas we were (supposed to, atleast i think) do these rebases from staging to stable, so thats why the slightly differently named topic.
--
To view, visit https://review.coreboot.org/20250
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9e715f09ef934bc36221b3e72c578ae96e0a3af
Gerrit-Change-Number: 20250
Gerrit-PatchSet: 1
Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 17 Jun 2017 08:40:45 +0000
Gerrit-HasComments: No