- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: programmer.h: sort programmer entries alphabetically
by Nico Huber (Code Review) 14 Jun '21

14 Jun '21

Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55495 ) Change subject: programmer.h: sort programmer entries alphabetically ...................................................................... Patch Set 1: (1 comment) File programmer.h: https://review.coreboot.org/c/flashrom/+/55495/comment/4e74386e_3ec3c1ae PS1, Line 86: extern const struct programmer_entry programmer_nicintel; > doesn't `nicintel` come before `nicintel_eeprom`? `env LC_ALL=C sort` says it does indeed. I do such things in vim, VISUAL LINE mode and :'<,'>!env LC_ALL=C sort actually just `:'<,'>!sort` because my LC_COLLATE is set to C anyway ;) -- To view, visit https://review.coreboot.org/c/flashrom/+/55495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Gerrit-Change-Number: 55495 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 14 Jun 2021 12:11:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: sort programmer entries alphabetically
by Angel Pons (Code Review) 14 Jun '21

14 Jun '21

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55495 ) Change subject: programmer.h: sort programmer entries alphabetically ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File programmer.h: https://review.coreboot.org/c/flashrom/+/55495/comment/c773c853_d3900eed PS1, Line 86: extern const struct programmer_entry programmer_nicintel; doesn't `nicintel` come before `nicintel_eeprom`? -- To view, visit https://review.coreboot.org/c/flashrom/+/55495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Gerrit-Change-Number: 55495 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 14 Jun 2021 12:00:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: sort programmer entries alphabetically
by Nico Huber (Code Review) 14 Jun '21

14 Jun '21

Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55495 ) Change subject: programmer.h: sort programmer entries alphabetically ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Gerrit-Change-Number: 55495 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 14 Jun 2021 11:35:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer.h: sort programmer entries alphabetically
by Thomas Heijligen (Code Review) 14 Jun '21

14 Jun '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55495 ) Change subject: programmer.h: sort programmer entries alphabetically ...................................................................... programmer.h: sort programmer entries alphabetically Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M programmer.h 1 file changed, 29 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/55495/1 diff --git a/programmer.h b/programmer.h index 9d1a9ad..558b80b 100644 --- a/programmer.h +++ b/programmer.h @@ -58,45 +58,45 @@ extern const size_t programmer_table_size; /* programmer drivers */ -extern const struct programmer_entry programmer_internal; -extern const struct programmer_entry programmer_dummy; -extern const struct programmer_entry programmer_nic3com; -extern const struct programmer_entry programmer_gfxnvidia; -extern const struct programmer_entry programmer_raiden_debug_spi; -extern const struct programmer_entry programmer_drkaiser; -extern const struct programmer_entry programmer_nicrealtek; -extern const struct programmer_entry programmer_nicnatsemi; -extern const struct programmer_entry programmer_nicintel; -extern const struct programmer_entry programmer_nicintel_spi; -extern const struct programmer_entry programmer_nicintel_eeprom; -extern const struct programmer_entry programmer_ogp_spi; -extern const struct programmer_entry programmer_satamv; -extern const struct programmer_entry programmer_satasii; extern const struct programmer_entry programmer_atahpt; -extern const struct programmer_entry programmer_atavia; extern const struct programmer_entry programmer_atapromise; -extern const struct programmer_entry programmer_it8212; -extern const struct programmer_entry programmer_ft2232_spi; -extern const struct programmer_entry programmer_usbblaster_spi; -extern const struct programmer_entry programmer_mstarddc_spi; -extern const struct programmer_entry programmer_pickit2_spi; -extern const struct programmer_entry programmer_stlinkv3_spi; -extern const struct programmer_entry programmer_rayer_spi; -extern const struct programmer_entry programmer_pony_spi; +extern const struct programmer_entry programmer_atavia; extern const struct programmer_entry programmer_buspirate_spi; -extern const struct programmer_entry programmer_linux_mtd; -extern const struct programmer_entry programmer_linux_spi; +extern const struct programmer_entry programmer_ch341a_spi; extern const struct programmer_entry programmer_dediprog; extern const struct programmer_entry programmer_developerbox; -extern const struct programmer_entry programmer_ch341a_spi; extern const struct programmer_entry programmer_digilent_spi; +extern const struct programmer_entry programmer_drkaiser; +extern const struct programmer_entry programmer_dummy; extern const struct programmer_entry programmer_ene_lpc; +extern const struct programmer_entry programmer_ft2232_spi; +extern const struct programmer_entry programmer_gfxnvidia; +extern const struct programmer_entry programmer_internal; +extern const struct programmer_entry programmer_it8212; extern const struct programmer_entry programmer_jlink_spi; -extern const struct programmer_entry programmer_ni845x_spi; -extern const struct programmer_entry programmer_mec1308; -extern const struct programmer_entry programmer_serprog; +extern const struct programmer_entry programmer_linux_mtd; +extern const struct programmer_entry programmer_linux_spi; extern const struct programmer_entry programmer_lspcon_i2c_spi; +extern const struct programmer_entry programmer_mec1308; +extern const struct programmer_entry programmer_mstarddc_spi; +extern const struct programmer_entry programmer_ni845x_spi; +extern const struct programmer_entry programmer_nic3com; +extern const struct programmer_entry programmer_nicintel_eeprom; +extern const struct programmer_entry programmer_nicintel_spi; +extern const struct programmer_entry programmer_nicintel; +extern const struct programmer_entry programmer_nicnatsemi; +extern const struct programmer_entry programmer_nicrealtek; +extern const struct programmer_entry programmer_ogp_spi; +extern const struct programmer_entry programmer_pickit2_spi; +extern const struct programmer_entry programmer_pony_spi; +extern const struct programmer_entry programmer_raiden_debug_spi; +extern const struct programmer_entry programmer_rayer_spi; extern const struct programmer_entry programmer_realtek_mst_i2c_spi; +extern const struct programmer_entry programmer_satamv; +extern const struct programmer_entry programmer_satasii; +extern const struct programmer_entry programmer_serprog; +extern const struct programmer_entry programmer_stlinkv3_spi; +extern const struct programmer_entry programmer_usbblaster_spi; int programmer_init(const struct programmer_entry *prog, const char *param); int programmer_shutdown(void); -- To view, visit https://review.coreboot.org/c/flashrom/+/55495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5 Gerrit-Change-Number: 55495 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: bitbang_spi.c: fix spi sequence in time and rename
by Xiang W (Code Review) 13 Jun '21

13 Jun '21

Attention is currently required from: Nico Huber, Stefan Reinauer. Xiang W has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49264 ) Change subject: bitbang_spi.c: fix spi sequence in time and rename ...................................................................... Patch Set 16: (1 comment) Patchset: PS16: It is necessary to add mode support, but there is an error in this interface. The bug of this interface existed before, and this interface was not added by me. This patch is almost half a year old, and I feel very tired if you do it like this. Whoever wants to do it. Angel Pons already has a copy of this patch, you can go over there to review -- To view, visit https://review.coreboot.org/c/flashrom/+/49264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I107803afef044996c94ebfaf0b0e0040cea9f8c1 Gerrit-Change-Number: 49264 Gerrit-PatchSet: 16 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Jun 2021 10:16:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: add support for Winbond W25Q01JV
by David Bartley (Code Review) 12 Jun '21

12 Jun '21

Attention is currently required from: Nico Huber, Angel Pons. David Bartley has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54968 ) Change subject: flashchips: add support for Winbond W25Q01JV ...................................................................... Patch Set 4: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/54968/comment/9f40060d_f00fed1b PS1, Line 17757: /* Full chip erase is fastest, typically takes 200s */ > > > Well, maybe there is one low-hanging fruit: For the erase commandline […] I'd be happy with just a flag that reverses the order, since I think we'd want it for normal writes too? When flashing new BIOS images, there's often overlap with what's written currently, so using smaller erasers can be an optimization (you can skip erasing/writing), but in this particular chip's case, that still results in very long flash times (almost an hour), compared to a full erase (2 min). -- To view, visit https://review.coreboot.org/c/flashrom/+/54968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If369409419332070c1fed96ce0e96b7cfe42c169 Gerrit-Change-Number: 54968 Gerrit-PatchSet: 4 Gerrit-Owner: David Bartley <andareed(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Jun 2021 18:27:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Bartley <andareed(a)gmail.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Move test environment header files into tests directory
by Edward O'Callaghan (Code Review) 12 Jun '21

12 Jun '21

Attention is currently required from: Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55408 ) Change subject: tests: Move test environment header files into tests directory ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55408 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia42773b98b1eb6c65241aa559c0c8b4926bd0814 Gerrit-Change-Number: 55408 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:43:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi.c: fix spi sequence in time and rename
by Angel Pons (Code Review) 12 Jun '21

12 Jun '21

Attention is currently required from: Nico Huber, Xiang W, Stefan Reinauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49264 ) Change subject: bitbang_spi.c: fix spi sequence in time and rename ...................................................................... Patch Set 16: Code-Review-2 (1 comment) Patchset: PS16: > SCK and MOSI should be changed at once and some bitbang programmers […] Definitely. -- To view, visit https://review.coreboot.org/c/flashrom/+/49264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I107803afef044996c94ebfaf0b0e0040cea9f8c1 Gerrit-Change-Number: 49264 Gerrit-PatchSet: 16 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:38:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi.c: fix spi sequence in time and rename
by Edward O'Callaghan (Code Review) 12 Jun '21

12 Jun '21

Attention is currently required from: Xiang W, Stefan Reinauer, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49264 ) Change subject: bitbang_spi.c: fix spi sequence in time and rename ...................................................................... Patch Set 16: -Code-Review (1 comment) Patchset: PS16: I noticed bits of this are in a long discussion in https://review.coreboot.org/c/flashrom/+/49255/28 -- To view, visit https://review.coreboot.org/c/flashrom/+/49264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I107803afef044996c94ebfaf0b0e0040cea9f8c1 Gerrit-Change-Number: 49264 Gerrit-PatchSet: 16 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:38:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric
by Edward O'Callaghan (Code Review) 12 Jun '21

12 Jun '21

Attention is currently required from: Nico Huber, Xiang W, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49262 ) Change subject: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric ...................................................................... Patch Set 25: -Code-Review (1 comment) Patchset: PS25: > Also CB:49264 I do now thanks for pointing it out! The patch stream is a bit confused and hard to following coming back to it. -- To view, visit https://review.coreboot.org/c/flashrom/+/49262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icf8b65aed20244ccffc231da2c599c6ca1796104 Gerrit-Change-Number: 49262 Gerrit-PatchSet: 25 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:35:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit