Attention is currently required from: Nico Huber, Angel Pons. David Bartley has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54968 )
Change subject: flashchips: add support for Winbond W25Q01JV ......................................................................
Patch Set 4:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/54968/comment/9f40060d_f00fed1b PS1, Line 17757: /* Full chip erase is fastest, typically takes 200s */
Well, maybe there is one low-hanging fruit: For the erase commandline […]
I'd be happy with just a flag that reverses the order, since I think we'd want it for normal writes too? When flashing new BIOS images, there's often overlap with what's written currently, so using smaller erasers can be an optimization (you can skip erasing/writing), but in this particular chip's case, that still results in very long flash times (almost an hour), compared to a full erase (2 min).
-
David Bartley (Code Review)