Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/55873
to look at the new patch set (#2).
Change subject: Makefile: Add macro to disable unsupported programmers
......................................................................
Makefile: Add macro to disable unsupported programmers
`mark_unsupported` disables all programmers passed as arguments and
adds them to the UNSUPPORTED_FEATURES list. It's conveniently used
with our dependency lists, e.g.
$(call mark_unsupported,$(NEEDS_LIBUSB1) $(NEEDS_LIBFTDI))
Change-Id: I6c9b66dfa89ec3d71675576d03fcebfdea30ce7b
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M Makefile
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/55873/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/55873
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6c9b66dfa89ec3d71675576d03fcebfdea30ce7b
Gerrit-Change-Number: 55873
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/55882
to look at the new patch set (#2).
Change subject: [DRAFT] Split Makefile
......................................................................
[DRAFT] Split Makefile
Now that the sections of the Makefile are somewhat visible again, it
actually looks well structured. How about splitting some of these
sections out?
Change-Id: I2fa86f8b686f61f09a8a5c929587ea71f3e59e78
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M Makefile
A Makefile.arch
A Makefile.defaults
A Makefile.deps
A Makefile.libs
A Makefile.os
A Makefile.programmers
7 files changed, 791 insertions(+), 693 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/82/55882/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/55882
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2fa86f8b686f61f09a8a5c929587ea71f3e59e78
Gerrit-Change-Number: 55882
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/55875
to look at the new patch set (#2).
Change subject: Makefile: Deflate handling of unsupported programmers for MinGW
......................................................................
Makefile: Deflate handling of unsupported programmers for MinGW
Change-Id: I20c17471f7b059e91b215fca833b767a003a9888
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M Makefile
1 file changed, 7 insertions(+), 102 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/55875/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/55875
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I20c17471f7b059e91b215fca833b767a003a9888
Gerrit-Change-Number: 55875
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons.
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/55872
to look at the new patch set (#2).
Change subject: Makefile: Gather lists of dependencies by feature/lib
......................................................................
Makefile: Gather lists of dependencies by feature/lib
For each feature or library that we treat as dependency, list which
programmers depend on it.
Change-Id: I6929181f18213e1434cbbc7ba2d2b0b04bd46a6a
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M Makefile
1 file changed, 49 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/55872/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/55872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6929181f18213e1434cbbc7ba2d2b0b04bd46a6a
Gerrit-Change-Number: 55872
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55872 )
Change subject: Makefile: Gather lists of dependencies by feature/lib
......................................................................
Patch Set 1:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/55872/comment/f251514f_519e2dc3
PS1, Line 107: CONFIG_ENE_LPC \
> Doesn't this undo CB:55869 though?
As always thanks for spotting! I need to be more careful with rebasing.
--
To view, visit https://review.coreboot.org/c/flashrom/+/55872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6929181f18213e1434cbbc7ba2d2b0b04bd46a6a
Gerrit-Change-Number: 55872
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Sun, 27 Jun 2021 19:16:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment