Attention is currently required from: Felix Singer, Nico Huber.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55866 )
Change subject: util: Name udev-rules file accordingly
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55866/comment/beeaa814_f5bf2203
PS1, Line 9: Rename `z60_flashrom.rules` to `flashrom_udev.rules`.
> Done
I’d got with `/lib/udev/rules.d/60-flashrom.rules` done by the Debian package [1]. Not every package maintainer should have to go through the trouble to determine how to order it.
[1]: https://packages.debian.org/sid/amd64/flashrom/filelist
--
To view, visit https://review.coreboot.org/c/flashrom/+/55866
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1e7918d3121d89d3c388745e433a3a413eac0e21
Gerrit-Change-Number: 55866
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Mon, 28 Jun 2021 08:30:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55876 )
Change subject: Makefile: Deflate handling of unsupported programmers for libpayload
......................................................................
Patch Set 2:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/55876/comment/b8043fbd_e54462ec
PS2, Line 240: $(call mark_unsupported,CONFIG_ENE_LPC CONFIG_MEC1308)
Untested with libpayload and hence disabled. Maybe we should simply disable them
by default, so the user can still enable them to try?
--
To view, visit https://review.coreboot.org/c/flashrom/+/55876
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I78ab1e3217aa6362b4c3525763e15140aa4c204f
Gerrit-Change-Number: 55876
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Victor Ding <victording(a)google.com>
Gerrit-Comment-Date: Mon, 28 Jun 2021 07:38:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55874 )
Change subject: Makefile: Deflate handling of unsupported programmers for DJGPP
......................................................................
Patch Set 2:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/55874/comment/70b5e3dd_65001028
PS2, Line 202: $(call mark_unsupported,CONFIG_ENE_LPC CONFIG_MEC1308)
Untested on DOS and hence disabled. Maybe we should simply disable them
by default, so the user can still enable them to try?
--
To view, visit https://review.coreboot.org/c/flashrom/+/55874
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I86988aa7ef1d2d4189be3d25b9aea4e7ddaec9af
Gerrit-Change-Number: 55874
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Victor Ding <victording(a)google.com>
Gerrit-Comment-Date: Mon, 28 Jun 2021 07:37:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55872 )
Change subject: Makefile: Gather lists of dependencies by feature/lib
......................................................................
Patch Set 2:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/55872/comment/f48f3dc8_c7dcb868
PS1, Line 107: CONFIG_ENE_LPC \
> As always thanks for spotting! I need to be more careful with rebasing.
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/55872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6929181f18213e1434cbbc7ba2d2b0b04bd46a6a
Gerrit-Change-Number: 55872
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 28 Jun 2021 07:35:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55887 )
Change subject: dediprog: Separate shutdown from failed init cleanup
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This is actually *the last one* which unlocks API change for register_shutdown!
--
To view, visit https://review.coreboot.org/c/flashrom/+/55887
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3273da907614a042d50090338c337dfd64695354
Gerrit-Change-Number: 55887
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 28 Jun 2021 07:21:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55887 )
Change subject: dediprog: Separate shutdown from failed init cleanup
......................................................................
dediprog: Separate shutdown from failed init cleanup
Shutdown function was covering two different jobs here: 1) the actual
shutdown which is run at the end of the driver's lifecycle and
2) cleanup in cases when initialisation failed. Now, shutdown is only
doing its main job (#1), and the driver itself is doing cleanup
when init fails (#2).
The good thing is that now resources are released/closed immediately
in cases when init fails (vs shutdown function which was run at some
point later), and the driver leaves clean space after itself if init
fails.
And very importantly this unlocks API change which plans to move
register_shutdown inside register master API, see
https://review.coreboot.org/c/flashrom/+/51761
BUG=b:185191942
TEST=builds
Change-Id: I3273da907614a042d50090338c337dfd64695354
Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M dediprog.c
1 file changed, 12 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/55887/1
diff --git a/dediprog.c b/dediprog.c
index 6a2d1f2..b47e8e9 100644
--- a/dediprog.c
+++ b/dediprog.c
@@ -1227,16 +1227,13 @@
msg_pinfo("Using dediprog id SF%06d.\n", found_id);
}
- if (register_shutdown(dediprog_shutdown, NULL))
- return 1;
-
/* Try reading the devicestring. If that fails and the device is old (FW < 6.0.0, which we can not know)
* then we need to try the "set voltage" command and then attempt to read the devicestring again. */
if (dediprog_check_devicestring()) {
if (dediprog_set_voltage())
- return 1;
+ goto init_err_cleanup_exit;
if (dediprog_check_devicestring())
- return 1;
+ goto init_err_cleanup_exit;
}
/* SF100/SF200 uses one in/out endpoint, SF600 uses separate in/out endpoints */
@@ -1261,11 +1258,11 @@
dediprog_set_spi_speed(spispeed_idx) ||
dediprog_set_spi_voltage(millivolt)) {
dediprog_set_leds(LED_ERROR);
- return 1;
+ goto init_err_cleanup_exit;
}
if (dediprog_standalone_mode())
- return 1;
+ goto init_err_cleanup_exit;
if ((dediprog_devicetype == DEV_SF100) ||
(dediprog_devicetype == DEV_SF600 && protocol() == PROTOCOL_V3))
@@ -1274,10 +1271,17 @@
if (protocol() >= PROTOCOL_V2)
spi_master_dediprog.features |= SPI_MASTER_4BA;
+ if (register_shutdown(dediprog_shutdown, NULL))
+ goto init_err_cleanup_exit;
+
if (register_spi_master(&spi_master_dediprog, NULL) || dediprog_set_leds(LED_NONE))
- return 1;
+ return 1; /* shutdown function does cleanup */
return 0;
+
+init_err_cleanup_exit:
+ dediprog_shutdown(NULL);
+ return 1;
}
const struct programmer_entry programmer_dediprog = {
--
To view, visit https://review.coreboot.org/c/flashrom/+/55887
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3273da907614a042d50090338c337dfd64695354
Gerrit-Change-Number: 55887
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newchange
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55881 )
Change subject: Makefile: Use dependency lists to generate NEED_<library> vars
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Patch set 2 works well with the default Manibuilder targets :)
--
To view, visit https://review.coreboot.org/c/flashrom/+/55881
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I30e6430a7e833a7f74eb973fb55bf1947ae2d87b
Gerrit-Change-Number: 55881
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 27 Jun 2021 23:31:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment