Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55877 )
Change subject: Makefile: Deflate handling of unsupported programmers for Linuxes
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55877/comment/5cb294a9_70f66b64
PS2, Line 7: Linuxes
The largest block is for not-Linux (-nor-Android), or am I missing something?
File Makefile:
https://review.coreboot.org/c/flashrom/+/55877/comment/e46b30a3_6f6d2acc
PS2, Line 259: override CONFIG_MSTARDDC_SPI = no
looks like an `endif` should be here.
--
To view, visit https://review.coreboot.org/c/flashrom/+/55877
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I17381172f8df213bbddccedec2ef288326e49ecf
Gerrit-Change-Number: 55877
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Mon, 28 Jun 2021 16:11:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55866 )
Change subject: util: Name udev-rules file accordingly
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55866/comment/3941535f_d934d6a5
PS1, Line 9: Rename `z60_flashrom.rules` to `flashrom_udev.rules`.
> I’d got with `/lib/udev/rules.d/60-flashrom.rules` done by the Debian package [1]. […]
If a distro uses any ordering concept (some also don't), then package maintainers _have_ to deal with that. This is their job, not ours.
--
To view, visit https://review.coreboot.org/c/flashrom/+/55866
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1e7918d3121d89d3c388745e433a3a413eac0e21
Gerrit-Change-Number: 55866
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 28 Jun 2021 14:33:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Victor Ding.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55890 )
Change subject: Allow MEC1308 to build against DOS and libpayload
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/flashrom/+/55890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic50fa2841b9e01b008ce82462e2b7120ee490a68
Gerrit-Change-Number: 55890
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Ding <victording(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Victor Ding <victording(a)google.com>
Gerrit-Comment-Date: Mon, 28 Jun 2021 09:53:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Victor Ding.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55889 )
Change subject: Allow ENE_LPC to build against DOS and libpayload
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/flashrom/+/55889
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0a7e675c344a2ccac558b8c32720930c15fe92ee
Gerrit-Change-Number: 55889
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Ding <victording(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Victor Ding <victording(a)google.com>
Gerrit-Comment-Date: Mon, 28 Jun 2021 09:53:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment