flashrom-gerrit April 2025

flashrom-gerrit@flashrom.org

1 participants
87 discussions

[M] Change in flashrom[main]: libflashrom: Add set log level functionality
by Anastasia Klimchuk (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Dmitry Zhadinets, NyeonWoo Kim, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87047?usp=email ) Change subject: libflashrom: Add set log level functionality ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/87047?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I095d48b8feb5fbc950a36eb17bed0d7cb8d9df64 Gerrit-Change-Number: 87047 Gerrit-PatchSet: 8 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: NyeonWoo Kim Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: NyeonWoo Kim Gerrit-Comment-Date: Tue, 01 Apr 2025 11:40:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Anastasia Klimchuk (Code Review) 01 Apr '25

01 Apr '25

Attention is currently required from: Dmitry Zhadinets, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 14 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 01 Apr 2025 11:34:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: libflashrom: Add API to return the list of supported programmers
by Dmitry Zhadinets (Code Review) 31 Mar '25

31 Mar '25

Attention is currently required from: Anastasia Klimchuk. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email ) Change subject: libflashrom: Add API to return the list of supported programmers ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > It is strange. Somehow commits has squashed. […] I will wait the merge of log API merge to rebase it because I will have conflicts in test/libflashrom.c -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 3 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 01 Apr 2025 00:32:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 31 Mar '25

31 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 13: (1 comment) File include/flash.h: https://review.coreboot.org/c/flashrom/+/86875/comment/9981c3e2_fe0cb3df?us… : PS13, Line 738: Therefore, any message exceeding 256 characters will not be printed, > It now gets truncated. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 13 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 01 Apr 2025 00:20:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 31 Mar '25

31 Mar '25

Attention is currently required from: Anastasia Klimchuk, Dmitry Zhadinets, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86875?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Code-Review+2 by Peter Marheine, Verified+1 by build bot (Jenkins) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... libflashrom: Update the API for Logger Callback The initial implementation does not account for user_data, requiring the calling application to use a global scope. This may lead to issues related to object lifecycle management and other architectural concerns. This patch adds user_data to the user’s log callback. Moreover, it performs message formatting, so the application only needs to pass the formatted string to the selected output. The change does not break the existing logging API but extends it. A new API version is introduced with the v2 suffix. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/flash.h M include/libflashrom.h M libflashrom.c M libflashrom.map M meson.build M meson_options.txt A tests/libflashrom.c M tests/meson.build M tests/tests.c M tests/tests.h 10 files changed, 153 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/86875/14 -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 14 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Add set log level functionality
by Dmitry Zhadinets (Code Review) 31 Mar '25

31 Mar '25

Attention is currently required from: Anastasia Klimchuk, NyeonWoo Kim, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87047?usp=email ) Change subject: libflashrom: Add set log level functionality ...................................................................... Patch Set 6: (4 comments) File libflashrom.c: https://review.coreboot.org/c/flashrom/+/87047/comment/1ed53918_472fe89a?us… : PS6, Line 6: * > I think it's about time to add a line for yourself here, and in the header, you are doing significan […] Done https://review.coreboot.org/c/flashrom/+/87047/comment/19fffc33_8c0ef7ca?us… : PS6, Line 36: enum flashrom_log_level global_log_level = FLASHROM_MSG_INFO; > It doesn't look like this needs external linkage, so it should be `static`. […] My bad. Done File tests/libflashrom.c: https://review.coreboot.org/c/flashrom/+/87047/comment/fcbc42b2_be0c5c1b?us… : PS6, Line 66: (void)state; /* unused */ : int user_data = 100500; : flashrom_set_log_callback_v2(test_log_callback_v2, &user_data); : flashrom_set_log_level(FLASHROM_MSG_WARN); > For readability, could you please re-arrange lines a bit, and add few new lines: […] Done https://review.coreboot.org/c/flashrom/+/87047/comment/2a66a1ab_e050cc28?us… : PS6, Line 91: /* check that callback is called after the change*/ > maybe a new line between 90-91, again so that flashrom_set_log_level be easily visible Done -- To view, visit https://review.coreboot.org/c/flashrom/+/87047?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I095d48b8feb5fbc950a36eb17bed0d7cb8d9df64 Gerrit-Change-Number: 87047 Gerrit-PatchSet: 6 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: NyeonWoo Kim Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: NyeonWoo Kim Gerrit-Comment-Date: Tue, 01 Apr 2025 00:15:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Add set log level functionality
by Dmitry Zhadinets (Code Review) 31 Mar '25

31 Mar '25

Attention is currently required from: Dmitry Zhadinets, NyeonWoo Kim. Hello Anastasia Klimchuk, NyeonWoo Kim, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/87047?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by NyeonWoo Kim, Verified+1 by build bot (Jenkins) Change subject: libflashrom: Add set log level functionality ...................................................................... libflashrom: Add set log level functionality Before this commit, any message from Flashrom would trigger the user's callback. This could lead to additional delays and slow down overall Flashrom performance. This patch adds the ability to configure the log level for messages from Flashrom. It sets the default log level to INFO Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Change-Id: I095d48b8feb5fbc950a36eb17bed0d7cb8d9df64 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M tests/libflashrom.c M tests/tests.c M tests/tests.h 5 files changed, 65 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/87047/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/87047?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I095d48b8feb5fbc950a36eb17bed0d7cb8d9df64 Gerrit-Change-Number: 87047 Gerrit-PatchSet: 7 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: NyeonWoo Kim Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: NyeonWoo Kim

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2025