April 2025 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[main]: doc: Update supported flashchips page because we split the large file
by Anastasia Klimchuk (Code Review) 05 Apr '25

05 Apr '25

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer. Hello Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86953?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Stefan Reinauer, Verified+1 by build bot (Jenkins) Change subject: doc: Update supported flashchips page because we split the large file ...................................................................... doc: Update supported flashchips page because we split the large file Change-Id: Ic6179517d0f951a32c0c4e0baf32677398224542 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/supported_hw/supported_flashchips.rst 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/86953/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/86953?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic6179517d0f951a32c0c4e0baf32677398224542 Gerrit-Change-Number: 86953 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: libflashrom: Added API to enumerate supported programmers
by Anastasia Klimchuk (Code Review) 05 Apr '25

05 Apr '25

Attention is currently required from: Dmitry Zhadinets. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email ) Change subject: libflashrom: Added API to enumerate supported programmers ...................................................................... Patch Set 10: (5 comments) Patchset: PS1: > If you are about iterator. […] But this is a good idea: `list_programmers_linebreak` iterates through programmers names, which is exactly what this new api returns. What do you mean about iterator? The new api which is introduced in this commit can be used with iterator - the test is doing this already. Patchset: PS3: > I had to remove next commits. […] Yes, I can't open that patch anymore, I understand you removed it. Although I can see your reply in the email, because the email was sent before the patch was removed :) I still plan to have a probe v2 (name TBD) and the cli will be its client. v1 will stay forever for anyone who uses it. This is also a stepping stone for more work that I want to do. But now it's all in my head, I will try to make a patch with it. This is not about this commit anyway. Commit Message: https://review.coreboot.org/c/flashrom/+/86921/comment/f238b58a_4848a8a2?us… : PS10, Line 7: libflashrom: Added API to enumerate supported programmers This title we changed earlier as `libflashrom: Add API to return the list of supported programmers` File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86921/comment/03e73265_96023409?us… : PS10, Line 199: no space here File tests/libflashrom.c: https://review.coreboot.org/c/flashrom/+/86921/comment/9a0e9aa7_0e9a2bdb?us… : PS10, Line 109: while (*(ptr++)) {} Maybe you can assert inside the loop that programmer name is not empty string (unless it's the last terminating 0) -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 10 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Comment-Date: Sat, 05 Apr 2025 09:28:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: cli: Set maximum log level for log callback
by Anastasia Klimchuk (Code Review) 05 Apr '25

05 Apr '25

Attention is currently required from: Dmitry Zhadinets, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/87174?usp=email ) Change subject: cli: Set maximum log level for log callback ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: > Yeah, It should be merged as soon as possible […] Yes, I will merge this tomorrow. I also thought about it on a fresh head in the morning, and what I said as "alternative approach" is actually I think needs to be done too, I made CB:87180 for it. The default should be, firstly, same as before (existing clients are not shocked), and secondly, we give clients all messages (don't make decision for them) and then they have choice if they want to lower the log level. As for our client, cli, I think it also makes sense to set the max log level explicitly. Whatever is the default, cli knows that it wants all messages in the callback. It's something that I realised only after merging the log level api change, but better later then never :) Patchset: PS2: Thanks so much everyone for quick reviews! -- To view, visit https://review.coreboot.org/c/flashrom/+/87174?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I70a02ea1a1d692267fd6d92cdb5273786a913777 Gerrit-Change-Number: 87174 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 05 Apr 2025 08:00:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: libflashrom: Set maximum log level SPEW by default
by Anastasia Klimchuk (Code Review) 05 Apr '25

05 Apr '25

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/87180?usp=email ) Change subject: libflashrom: Set maximum log level SPEW by default ...................................................................... libflashrom: Set maximum log level SPEW by default This log level is the maximum level that will trigger the log callback. By default log callback should be triggered for all messages, and then client can decide whether they want to lower the level. This also keeps the same behaviour for existing clients of libflashrom, the same as it was before introducing the ability to set max log level in log callback API. Follow up on commit 4e334c4f79da2b621917da8f47dcf33bb2c0cfbc Change-Id: Id063c31e685c930b9f5632c7b86ffac6fe477fd5 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M libflashrom.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/87180/1 diff --git a/libflashrom.c b/libflashrom.c index a9aff50..888ca05 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -34,7 +34,7 @@ static flashrom_log_callback *global_log_callback = NULL; static flashrom_log_callback_v2 *global_log_callback_v2 = NULL; static void *global_log_user_data = NULL; -static enum flashrom_log_level global_log_level = FLASHROM_MSG_INFO; +static enum flashrom_log_level global_log_level = FLASHROM_MSG_SPEW; int flashrom_init(const int perform_selfcheck) { -- To view, visit https://review.coreboot.org/c/flashrom/+/87180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id063c31e685c930b9f5632c7b86ffac6fe477fd5 Gerrit-Change-Number: 87180 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: cli: Set maximum log level for log callback
by Stefan Reinauer (Code Review) 04 Apr '25

04 Apr '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/87174?usp=email ) Change subject: cli: Set maximum log level for log callback ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/87174?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I70a02ea1a1d692267fd6d92cdb5273786a913777 Gerrit-Change-Number: 87174 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 04 Apr 2025 22:16:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: libflashrom: Added API to enumerate supported programmers
by Dmitry Zhadinets (Code Review) 04 Apr '25

04 Apr '25

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86921?usp=email to look at the new patch set (#10). Change subject: libflashrom: Added API to enumerate supported programmers ...................................................................... libflashrom: Added API to enumerate supported programmers There were no options available to obtain the list of programmers. The implementation is based on flashrom_supported_flash_chips. Arrays of constant strings are returned, and the array must be freed using flashrom_data_free. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/libflashrom.c M tests/tests.c M tests/tests.h 6 files changed, 39 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/86921/10 -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 10 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: libflashrom: Added API to enumerate supported programmers
by Dmitry Zhadinets (Code Review) 04 Apr '25

04 Apr '25

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86921?usp=email to look at the new patch set (#9). Change subject: libflashrom: Added API to enumerate supported programmers ...................................................................... libflashrom: Added API to enumerate supported programmers There were no options available to obtain the list of programmers. The implementation is based on flashrom_supported_flash_chips. Arrays of constant strings are returned, and the array must be freed using flashrom_data_free. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/libflashrom.c M tests/tests.c M tests/tests.h 6 files changed, 39 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/86921/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 9 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: libflashrom: Added API to enumerate supported programmers
by Dmitry Zhadinets (Code Review) 04 Apr '25

04 Apr '25

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86921?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: libflashrom: Added API to enumerate supported programmers ...................................................................... libflashrom: Added API to enumerate supported programmers There were no options available to obtain the list of programmers. The implementation is based on flashrom_supported_flash_chips. Arrays of constant strings are returned, and the array must be freed using flashrom_data_free. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/libflashrom.c M tests/tests.c M tests/tests.h 6 files changed, 39 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/86921/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 8 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Added API to enumerate supported programmers
by Dmitry Zhadinets (Code Review) 04 Apr '25

04 Apr '25

Attention is currently required from: Anastasia Klimchuk. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email ) Change subject: libflashrom: Added API to enumerate supported programmers ...................................................................... Patch Set 7: (4 comments) Patchset: PS3: > Looks like your link does not work. […] I had to remove next commits. Lest merge step by step File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86921/comment/7b971c28_a538c401?us… : PS3, Line 159: const char *flashrom_get_programmer_name(int n) : { : if (n < 0 || (size_t)n >= programmer_table_size) : return NULL; : return programmer_table[n]->name; : } > It is because of my squashed commits. I re-based it not is it here in another commit. […] I had to remove next commits. Lest merge step by step File tests/libflashrom.c: https://review.coreboot.org/c/flashrom/+/86921/comment/7df83cb9_909acce2?us… : PS3, Line 40: #if CONFIG_DUMMY == 1 > Again, my swashed commits . it is here now https://review.coreboot.org/c/flashrom/+/86946/3 […] I had to remove next commits. Lest merge step by step https://review.coreboot.org/c/flashrom/+/86921/comment/534db42f_54a44b82?us… : PS3, Line 62: > Fixed here https://review.coreboot. […] I had to remove next commits. Lest merge step by step -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 7 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 04 Apr 2025 17:23:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Added API to enumerate supported programmers
by Dmitry Zhadinets (Code Review) 04 Apr '25

04 Apr '25

Attention is currently required from: Anastasia Klimchuk. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86921?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: libflashrom: Added API to enumerate supported programmers ...................................................................... libflashrom: Added API to enumerate supported programmers There were no options available to obtain the list of programmers. The implementation is based on flashrom_supported_flash_chips. Arrays of constant strings are returned, and the array must be freed using flashrom_data_free. Testing: Both unit tests and CLI tools serve as libflashrom clients. All unit tests run successfully. Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Signed-off-by: Dmitry Zhadinets <dzhadinets(a)gmail.com> --- M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/libflashrom.c M tests/tests.c M tests/tests.h 6 files changed, 102 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/86921/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 7 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2025